Differential D14225
Fix T95479: Geometry nodes crash with cage display. Authored by Jacques Lucke (JacquesLucke) on Mar 2 2022, 2:21 PM. Tags None Subscribers None Tokens
Details Since the geometry nodes modifier has the eModifierTypeFlag_SupportsMapping flag, it is assumed that its output contains the CD_ORIGINDEX layers. A non-existant layer means that there is a 1:1 mapping, which is generally not the case. How can we check whether these layers are actually needed? Should we check if the object is in edit mode with the cage option enabled or is there some utility?
Diff Detail
Event TimelineComment Actions
A modifier is expected to preserve custom data, interpolating it when possible.
Is not only used for cage and edit mode, but also by things like vertex parent which averages vertex positions which maps back to a specific original vertex index. Comment Actions It's too bad this is necessary, but it's the simplest fix for now, so it seems fine to me. Comment Actions
Comment Actions Logic here looks good to me still, an improvement. Since the modifier stack should have added the orig index layers to the input if they're necessary. |