Fix T93573: Curve evaluated mesh selected in edit mode
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Mar 2 2022, 7:35 PM.

Details

Reviewers

Clément Foucault (fclem)
Jeroen Bakker (jbakker)

Maniphest Tasks

T93573: Regression: Selection outline of curves in edit mode

Commits

rB2b3367cdf869: Fix T93573: Curve evaluated mesh selected in edit mode

Summary

This fixes the second part of T93573 that 8506f3d9fe9359518e didn't
properly address. Specifically, outlines of instances still had the
selected color in edit mode in wireframe view.

This change is the same as the commit above, just in a different place.
There is a third similar place in DRW_object_wire_theme_get, but
I'm not sure if it's necessary to change that to fix anything related to
this problem. So far I don't think so.

Before Object Mode	Before Edit Mode	After Object Mode	After Edit Mode

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Mar 2 2022, 7:35 PM

Hans Goudey (HooglyBoogly) created this revision.

Hans Goudey (HooglyBoogly) added a task: T93573: Regression: Selection outline of curves in edit mode.

Still misses the curve line itself.

Hans Goudey (HooglyBoogly) planned changes to this revision.Mar 2 2022, 8:12 PM

In D14229#380135, @Philipp Oeser (lichtwerk) wrote:

Still misses the curve line itself.

To make that visual: it should look like this (unless there is a clear design decision to not draw the curve itself? would highly doubt that though...):

In D14229#380135, @Philipp Oeser (lichtwerk) wrote:

Still misses the curve line itself.

Regarding the line of the curve between the edit mode points, that's a separate issue that this patch doesn't aim to solve.

Hans Goudey (HooglyBoogly) requested review of this revision.Mar 2 2022, 8:21 PM

In D14229#380139, @Hans Goudey (HooglyBoogly) wrote:

In D14229#380135, @Philipp Oeser (lichtwerk) wrote:

Still misses the curve line itself.

Regarding the line of the curve between the edit mode points, that's a separate issue that this patch doesn't aim to solve.