Replace MFace Usage by MLoopTri in MOD_laplaciansmooth.c
AbandonedPublic
Actions

Authored by Campbell Barton (campbellbarton) on Jul 20 2015, 1:48 PM.

Details

Reviewers

Martin Felke (scorpion81)
Antonis Ryakiotakis (psy-fi)

Summary

This patch attempts to replace MFace Usage by MLoopTri in MOD_laplaciansmooth.c
Note: this requires some help, because I couldnt get the exact former behavior of the modifier...
so this is a preliminary patch. I am open to suggestions how to fix.
Subtask of T45474 .

Diff Detail

Repository: rB Blender
Branch: arcpatch-D1422

Event Timeline

Martin Felke (scorpion81) updated this revision to Diff 4712.Jul 20 2015, 1:48 PM

Martin Felke (scorpion81) retitled this revision from to Replace MFace Usage by MLoopTri in MOD_laplaciansmooth.c.

Martin Felke (scorpion81) updated this object.

Martin Felke (scorpion81) added reviewers: Campbell Barton (campbellbarton), Antonis Ryakiotakis (psy-fi).

Martin Felke (scorpion81) added a project: BF Blender: Next.

Theres no need to make an edge-hash here, you can just inspect the looptri's edge, and check if it runs along the same vertices as the looptri's.

minor edits

removed edgehash and comparing edges with looptri edges / verts now.

Campbell Barton (campbellbarton) added inline comments.Jul 23 2015, 8:52 PM

source/blender/modifiers/intern/MOD_laplaciansmooth.c
318–320	On IRC you reported that the results with this patch were different from 2.75a. This would definitely be one reason why, since its adding the weight of a tessellated corner. I think its worth to investigate supporting ngon's for this code, where each corner is calculated and evaluated based on the 2 adjacent verts of the loop. And the area is calculated on the polygon.