Page MenuHome
Differential D1423

Initial uiWidget architecture Refactor
AbandonedPublic
Actions

Authored by Julian Eisel (Severin) on Jul 20 2015, 1:50 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Antonis Ryakiotakis (psy-fi)
Ton Roosendaal (ton)
Summary

Initial uiWidget architecture Refactor

Aiming towards the following goals:

  • Widget Draw Styles (see T45025 - heavily overlaps with this)
  • Isolating widget code to make it more future proof
  • Adding callback based widgets handling module (currently handled in interface_handler.c)

Adds the following folders/files:
interface/widgets/
interface/widgets/widgets.c
interface/widgets/widgets.h
interface/widgets/widgets_draw/
interface/widgets/widgets_draw/drawstyle_classic.c
interface/widgets/widgets_draw/widgets_draw.c
interface/widgets/widgets_draw/widgets_draw_text.c
interface/widgets/widgets_draw/widgets_draw_intern.h

Branch: temp-ui-widget-refactor

Will add some more info here soonish

NOTE: This is still WIP, but thought it might be good to start reviewing early on (mainly general architecture changes).

WIP doc: http://wiki.blender.org/index.php/User:Julianeisel/ui-widgets

Diff Detail

Repository
rB Blender
Branch
temp-ui-widget-refactor

Event Timeline

Julian Eisel (Severin) updated this revision to Diff 4711.Jul 20 2015, 1:50 PM
Julian Eisel (Severin) retitled this revision from to Initial uiWidget architecture Refactor.
Julian Eisel (Severin) updated this object.
Julian Eisel (Severin) added reviewers: Campbell Barton (campbellbarton), Antonis Ryakiotakis (psy-fi), Ton Roosendaal (ton), Brecht Van Lommel (brecht).
Julian Eisel (Severin) set the repository for this revision to rB Blender.
Julian Eisel (Severin) added a project: User Interface.
Julian Eisel (Severin) updated this object.
Julian Eisel (Severin) updated this object.Jul 20 2015, 1:55 PM
Julian Eisel (Severin) updated this object.
Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).Jul 23 2015, 9:33 AM
Sergey Sharybin (sergey) added inline comments.
source/blender/editors/interface/widgets/widgets.c
71

This worth making an init() callback of widget type instead of having it all hardcoded here.

Campbell Barton (campbellbarton) requested changes to this revision.Jul 23 2015, 9:36 AM
Campbell Barton (campbellbarton) edited edge metadata.

Hey, checked and works fine, so nice start :)

General feedback on the way forward...

  • We should first have 2... probably 3 different token styles (maybe one totally simple, another a variation of classic? --- just to save time).
  • Figure out what functions should be shared between then and move into utility module.
  • Then finalize styles (probably improve and keep the 'simple' style), for merging into master.

With only one style, think its too hard to evaluate the patch, its just moving functions about (which is good), but not significant enough to approve.

This revision now requires changes to proceed.Jul 23 2015, 9:36 AM
Julian Eisel (Severin) added a comment.Jul 23 2015, 8:05 PM

@Campbell Barton (campbellbarton), yep, still agree on adding another style to check if everything is working, but wanted to get overall refactor changes done and approved first. Will start working on that soon.

source/blender/editors/interface/widgets/widgets.c
71

Not really sure what you mean here tbh ;P

Like:

void (*init)(...)
...
    case UI_WTYPE_FOO:
        init = widget_init_foo;
        break;
...
init(...);

?

Jonathan Williamson (carter2422) added a subscriber: Jonathan Williamson (carter2422).Jul 27 2015, 5:00 PM
Julian Eisel (Severin) updated this object.Aug 2 2015, 1:57 AM
Julian Eisel (Severin) edited edge metadata.
Julian Eisel (Severin) updated this object.Aug 2 2015, 2:38 AM
Jacob Merrill (blueprintrandom) added a subscriber: Jacob Merrill (blueprintrandom).Aug 2 2015, 4:21 AM
Julian Eisel (Severin) added a child revision: D1464: Interface Draw-styles: Basic Implementation and "Flat" Test Style.Aug 15 2015, 2:19 AM
Julian Eisel (Severin) updated this revision to Diff 4863.Aug 15 2015, 2:25 AM
Julian Eisel (Severin) edited edge metadata.

Update patch to work with D1464

Campbell Barton (campbellbarton) removed a reviewer: Campbell Barton (campbellbarton).Aug 11 2016, 6:05 AM
Julian Eisel (Severin) abandoned this revision.Mar 26 2020, 1:48 PM

This was an interesting experiment, but I'm not too sure it's the best way forward (I rather spend time on https://github.com/julianeisel/bWidgets ;) ). The code is quite outdated too.

Julian Eisel (Severin) mentioned this in D1464: Interface Draw-styles: Basic Implementation and "Flat" Test Style.Mar 26 2020, 1:48 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
interface/
8 lines
2 lines
260 lines
47 lines
3986 lines
widgets/
181 lines
295 lines
widgets_draw/
1623 lines
879 lines
109 lines
911 lines

Diff 4863

View Options

source/blender/editors/interface/CMakeLists.txt

Loading...
View Options

source/blender/editors/interface/interface.c

Loading...
View Options

source/blender/editors/interface/interface_draw.c

Loading...
View Options

source/blender/editors/interface/interface_intern.h

Loading...
View Options

source/blender/editors/interface/interface_widgets.c

Loading...
View Options

source/blender/editors/interface/widgets/widgets.h

Loading...
View Options

source/blender/editors/interface/widgets/widgets.c

Loading...
View Options

source/blender/editors/interface/widgets/widgets_draw/drawstyle_classic.c

Loading...
View Options

source/blender/editors/interface/widgets/widgets_draw/widgets_draw.c

Loading...
View Options

source/blender/editors/interface/widgets/widgets_draw/widgets_draw_intern.h

Loading...
View Options

source/blender/editors/interface/widgets/widgets_draw/widgets_draw_text.c

Loading...