Page MenuHome

Fix T95591: Crash on drawing with measure tool with tweak fallback tool
ClosedPublic

Authored by Campbell Barton (campbellbarton) on Mar 3 2022, 2:25 AM.

Details

Summary

Using press to activate the Tweak tool doesn't work well when used a fallback tool as the drag event is often used by the current tool - making it impossible not to select when dragging (unless the fallback tool is disabled entirely).
Resolve this by using CLICK events when the Tweak tool is used as a fallback.

Even though this avoids the crash, check for null-pointer de-reference since changes to the key-map shouldn't cause operators to crash.

Note that the ability for operators to access a gizmo before it's fully initialized is a more general problem that should be addressed, but out of scope for a bug-fix.

Diff Detail

Repository
rB Blender

Event Timeline

Campbell Barton (campbellbarton) requested review of this revision.Mar 3 2022, 2:25 AM
Campbell Barton (campbellbarton) created this revision.

Further clarify comment wording.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 3 2022, 5:35 AM
This revision was automatically updated to reflect the committed changes.

Rebase on blender-v3.1-release

I tested it. From my user point of view it works well.

This revision is now accepted and ready to land.Mar 7 2022, 10:32 AM

Seems fine for the release.

release/scripts/presets/keyconfig/keymap_data/blender_default.py
449 ↗(On Diff #48877)

There's something missing here I think? Sentence doesn't make much sense :)

  • Rebase on 3.1 branch, correct sentence structure of comment.
Campbell Barton (campbellbarton) added inline comments.
release/scripts/presets/keyconfig/keymap_data/blender_default.py
449 ↗(On Diff #48877)

Indeed! Updated it should be clearer now.

Campbell Barton (campbellbarton) marked an inline comment as done.

Further clarify comment.