Page MenuHome
Differential D14253

Fix T92331: Duplicated Window Should Not Be Modal
ClosedPublic
Actions

Authored by Harley Acheson (harley) on Mar 6 2022, 8:10 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rB353376c78339: Fix T92331: Duplicated Window Should Not Be Modal
Summary

Operator area_dupli_invoke should not create modal windows.

When I refactored some of the window creation code in D10419: UI: Simplify Window Creation I had intended to not make any behavior changes, but failed in one case. Operator area_dupli_invoke is now creating windows that are set "modal" where they were not before my changes. I didn't notice this because on my platform (Windows) such windows are not treated differently. But on Mac they are treated as modal, which is not correct for this operator.

Diff Detail

Repository
rB Blender

Event Timeline

Harley Acheson (harley) requested review of this revision.Mar 6 2022, 8:10 PM
Harley Acheson (harley) created this revision.
Brecht Van Lommel (brecht) accepted this revision.Mar 6 2022, 9:14 PM
This revision is now accepted and ready to land.Mar 6 2022, 9:14 PM
Harley Acheson (harley) removed a reviewer: Yevgeny Makarov (jenkm).Mar 8 2022, 10:56 PM
Closed by commit rB353376c78339: Fix T92331: Duplicated Window Should Not Be Modal (authored by Harley Acheson (harley)). · Explain WhyMar 8 2022, 10:57 PM
This revision was automatically updated to reflect the committed changes.
Harley Acheson (harley) added a commit: rB353376c78339: Fix T92331: Duplicated Window Should Not Be Modal.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
screen/
2 lines

Diff 49067

View Options

source/blender/editors/screen/screen_ops.c

Loading...