Differential D14256

Fix T96207: Change default value of Specular tint
AbandonedPublic
Actions

Authored by Hallam Roberts (MysteryPancake) on Mar 7 2022, 1:37 AM.

Details

Reviewers

Aaron Carlisle (Blendify)

Commits

rBe908ebc0947d: Fix T96207: wrong default value of Principled BSDF specular tint

Summary

This fixes the regression described in T96207

Diff Detail

Repository

rB Blender

Branch

changedefault (branched from master)

Build Status

Buildable 20855
Build 20855: arc lint + arc unit

Event Timeline

Hallam Roberts (MysteryPancake) requested review of this revision.Mar 7 2022, 1:37 AM

Hallam Roberts (MysteryPancake) created this revision.

Harbormaster completed remote builds in B20855: Diff 48948.Mar 7 2022, 1:37 AM

Hallam Roberts (MysteryPancake) mentioned this in T96207: Principled BSDF - Specular Tint default value at 0.5.Mar 7 2022, 1:38 AM

Hallam Roberts (MysteryPancake) retitled this revision from Fix regression T96207 to Fix regression.

Hallam Roberts (MysteryPancake) edited the summary of this revision. (Show Details)

Hallam Roberts (MysteryPancake) added a reviewer: Aaron Carlisle (Blendify).

Hallam Roberts (MysteryPancake) retitled this revision from Fix regression to Fix regression caused by ed9b21098dd2.Mar 7 2022, 1:40 AM

Ethan Hall (Ethan1080) mentioned this in rBed9b21098dd2: Cleanup: Use new socket builder API.Mar 7 2022, 1:42 AM

Pratik Borhade (PratikPB2123) retitled this revision from Fix regression caused by ed9b21098dd2 to Fix T96207: Change default value of Specular tint.Mar 7 2022, 4:20 AM

Pratik Borhade (PratikPB2123) edited the summary of this revision. (Show Details)

Ethan Hall (Ethan1080) mentioned this in D14257: Shader Nodes: Changes to node UI and default values to improve consistency.Mar 7 2022, 6:16 AM

Ethan's patch fixes additional inconsistency: https://developer.blender.org/D14257

Will keep this patch open just in case for now

Ethan Hall (Ethan1080) awarded a token.Mar 7 2022, 6:25 AM

Closed in favour of D14257

Best not to mix bug fixes with other changes, I will commit this by itself to 3.1.

Note for future patches, if you want the commit to have your name in the git author field, you need to provide a real name in your account. Otherwise it will only be an account name in the commit description.

Brecht Van Lommel (brecht) added a commit: rBe908ebc0947d: Fix T96207: wrong default value of Principled BSDF specular tint.Mar 7 2022, 2:54 PM

In D14256#381070, @Brecht Van Lommel (brecht) wrote:

Note for future patches, if you want the commit to have your name in the git author field, you need to provide a real name in your account. Otherwise it will only be an account name in the commit description.

For future reference is this a written policy somewhere?

Just saw the commit, thanks

In D14256#381092, @Aaron Carlisle (Blendify) wrote:

For future reference is this a written policy somewhere?

See here:
https://wiki.blender.org/wiki/Style_Guide/Commit_Messages#Author_.2F_Committer

Revision Contents
Changeset List

Path

Size

source/

blender/

nodes/

shader/

nodes/

node_shader_bsdf_principled.cc

2 lines

Diff 48948

View Options

source/blender/nodes/shader/nodes/node_shader_bsdf_principled.cc

Fix T96207: Change default value of Specular tintAbandonedPublicActions