Shader Nodes: Changes to node UI and default values to improve consistency
Needs ReviewPublic
Actions

Authored by Ethan Hall (Ethan1080) on Mar 7 2022, 6:09 AM.

Details

Reviewers

Aaron Carlisle (Blendify)
Brecht Van Lommel (brecht)

Summary

This patch makes a few changes to improve these three shader nodes.
It address my comments on https://developer.blender.org/rBed9b21098dd27bf9364397357f89b4c2648f40c2

This patch also includes the same change as: https://developer.blender.org/D14256
Which fixes: https://developer.blender.org/T96207

Diff Detail

Repository

rB Blender

Branch

ui_tweak_shader_nodes (branched from master)

Build Status

Buildable 20857
Build 20857: arc lint + arc unit

Event Timeline

Ethan Hall (Ethan1080) requested review of this revision.Mar 7 2022, 6:09 AM

Ethan Hall (Ethan1080) created this revision.

Harbormaster completed remote builds in B20856: Diff 48949.Mar 7 2022, 6:09 AM

Ethan Hall (Ethan1080) edited the summary of this revision. (Show Details)Mar 7 2022, 6:16 AM

Ethan Hall (Ethan1080) added a subscriber: Aaron Carlisle (Blendify).

Ethan Hall (Ethan1080) mentioned this in rBed9b21098dd2: Cleanup: Use new socket builder API.Mar 7 2022, 6:19 AM

Hallam Roberts (MysteryPancake) awarded a token.Mar 7 2022, 6:20 AM

Hallam Roberts (MysteryPancake) mentioned this in D14256: Fix T96207: Change default value of Specular tint.Mar 7 2022, 6:24 AM

Hallam Roberts (MysteryPancake) added a subscriber: Hallam Roberts (MysteryPancake).Mar 7 2022, 6:34 AM

Hallam Roberts (MysteryPancake) added inline comments.

source/blender/nodes/shader/nodes/node_shader_eevee_specular.cc

29–30

These changes require versioning code in versioning_300:

if (!MAIN_VERSION_ATLEAST(bmain, 302, 3)) {
  FOREACH_NODETREE_BEGIN (bmain, ntree, id) {
    if (ntree->type == NTREE_SHADER) {
      version_node_input_socket_name(ntree, SH_NODE_EEVEE_SPECULAR, "Clear Coat", "Clearcoat");
      version_node_input_socket_name(ntree, SH_NODE_EEVEE_SPECULAR, "Clear Coat Roughness", "Clearcoat Roughness");
      version_node_input_socket_name(ntree, SH_NODE_EEVEE_SPECULAR, "Clear Coat Normal", "Clearcoat Normal");
    }
  }
  FOREACH_NODETREE_END;
}

Fixed versioning

Harbormaster completed remote builds in B20857: Diff 48950.Mar 7 2022, 6:58 AM

@Hallam Roberts (MysteryPancake) Thanks for spotting that.

Hallam Roberts (MysteryPancake) added a reviewer: Aaron Carlisle (Blendify).Mar 7 2022, 7:41 AM

Ethan Hall (Ethan1080) added projects: BF Blender, User Interface, Nodes & Physics.Mar 7 2022, 7:44 AM

Standardized emission color naming

Harbormaster completed remote builds in B20860: Diff 48955.Mar 7 2022, 9:02 AM

If you look at the Principle BSDF and Specular BSDF, you will notice that the clearcoat sockets are ordered differently.
I'm waiting to hear which style is better, but making the order consistent could be a part of this patch.

EDIT
This idea will have to wait for another patch, changing node order is a complicated versioning problem.

The Principle BSDF node's Subsurface IOR, Principal Hair BSDF node's IOR, and Subsurface Scattering node's IOR are of the subtype PROP_FACTOR. Everywhere else that I can find the subtype for IOR Is left as default. I personally prefer making the subtype PROP_FACTOR everywhere since it makes fine tuning easier.

Waiting to hear which is better, but making IOR subtypes consistent could be a part of this patch.

Ethan Hall (Ethan1080) added subscribers: Brecht Van Lommel (brecht), Clément Foucault (fclem).Mar 7 2022, 1:43 PM

Ethan Hall (Ethan1080) retitled this revision from -Made changes to shader nodes UI and default values to improve consistency to Shader Nodes: Changes to node UI and default values to improve consistency.Mar 7 2022, 2:03 PM

Brecht Van Lommel (brecht) mentioned this in T96219: Breaking shader node changes.Mar 7 2022, 2:16 PM