Differential D14259

Fix T96163: Image editor doesn't refresh when undo/redo.
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Mar 7 2022, 8:34 AM.

Details

Reviewers

Bastien Montagne (mont29)

Maniphest Tasks

T96163: Regression: Image editor fails to update after undoing stroke

Commits

rB073d2390f0b8: Fix T96163: Image editor doesn't refresh when undo/redo.

Summary

Undo would invalidate image owned GPU textures only. Textures
that are owned by the editor were not refreshed. This patch would
invalidate all the GPU textures by marking the whole image dirty.

This can be improved later as we could add partial updates of GPU
textures.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Mar 7 2022, 8:34 AM

Harbormaster completed remote builds in B20859: Diff 48953.Mar 7 2022, 8:34 AM

Jeroen Bakker (jbakker) requested review of this revision.Mar 7 2022, 8:34 AM

Jeroen Bakker (jbakker) added a reviewer: Bastien Montagne (mont29).Mar 7 2022, 8:35 AM

Jeroen Bakker (jbakker) added projects: BF Blender (3.1), Restricted Project, Images & Movies.

Makes sense to me.

This revision is now accepted and ready to land.Mar 7 2022, 8:42 AM

Closed by commit rB073d2390f0b8: Fix T96163: Image editor doesn't refresh when undo/redo. (authored by Jeroen Bakker (jbakker)). · Explain WhyMar 7 2022, 8:44 AM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rB073d2390f0b8: Fix T96163: Image editor doesn't refresh when undo/redo..

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_image/

image_undo.c

3 lines

Diff 48954

View Options

source/blender/editors/space_image/image_undo.c

Fix T96163: Image editor doesn't refresh when undo/redo.ClosedPublicActions