GPU: disable compute shader for problematic drivers
ClosedPublic
Actions

Authored by Kévin Dietrich (kevindietrich) on Mar 7 2022, 4:42 PM.

Details

Reviewers

Clément Foucault (fclem)
Jeroen Bakker (jbakker)

Commits

rB3a672fe6fbdc: GPU: disable compute shader for problematic drivers

Summary

Some drivers for legacy platforms seem to have issues with compute
shaders, as revealed by T94936. This disables compute shader for the
known drivers where this issue is present. It is not clear if the issue
is Windows only or not, so this disable them for all operating systems.

See T94936 for a list of configurations where the issue is reproducible
or not.

Diff Detail

Repository

rB Blender

Branch

gpu_compute_blacklist (branched from master)

Build Status

Buildable 20883
Build 20883: arc lint + arc unit

Event Timeline

Kévin Dietrich (kevindietrich) requested review of this revision.Mar 7 2022, 4:42 PM

Kévin Dietrich (kevindietrich) created this revision.

Harbormaster completed remote builds in B20883: Diff 48984.Mar 7 2022, 4:42 PM

I find it strange that the core issue is a lack of support of compute shaders. Maybe it is just a bug in the shader compiler that makes this particular shader produce. the wrong output This is concerning as we are planning to require compute shader support in the near future.

However, I find the blacklist approach okay for a hotfix. A more consistent fix would be to find a workaround or disable only opensubdiv gpu compute backend.

This revision is now accepted and ready to land.Mar 7 2022, 8:17 PM

Closed by commit rB3a672fe6fbdc: GPU: disable compute shader for problematic drivers (authored by Kévin Dietrich (kevindietrich)). · Explain WhyMar 8 2022, 1:47 PM

This revision was automatically updated to reflect the committed changes.

Kévin Dietrich (kevindietrich) added a commit: rB3a672fe6fbdc: GPU: disable compute shader for problematic drivers.