Paths

Table of Contentst

Differential D14278

Fix T96224: GPU subdiv crash with smooth normals and tangents
ClosedPublic
Actions

Authored by Kévin Dietrich (kevindietrich) on Mar 8 2022, 1:33 PM.

Tags

Subscribers

None

Details

Reviewers

Clément Foucault (fclem)
Jeroen Bakker (jbakker)

Maniphest Tasks

T96224: Tangent shader node & subdivision surface crashes blender

Commits

rBd5e4cab76c62: Fix T96224: GPU subdiv crash with smooth normals and tangents

Summary

Tangents are computed from UVs on the CPU side when using GPU subdivision
and require that the normals are available there as well (at least for smooth
shading, flat normals can be computed on the fly). This simply adds the missing
normals update call for the MeshRenderData setup for the subdivision case.

Diff Detail

Repository: rB Blender

Event Timeline

Kévin Dietrich (kevindietrich) requested review of this revision.Mar 8 2022, 1:33 PM

Kévin Dietrich (kevindietrich) created this revision.

Harbormaster completed remote builds in B20907: Diff 49029.Mar 8 2022, 1:33 PM

Kévin Dietrich (kevindietrich) added a project: EEVEE & Viewport.Mar 8 2022, 1:34 PM

Kévin Dietrich (kevindietrich) added a task: T96224: Tangent shader node & subdivision surface crashes blender.

Clément Foucault (fclem) accepted this revision.Mar 8 2022, 1:44 PM

This revision is now accepted and ready to land.Mar 8 2022, 1:44 PM

Closed by commit rBd5e4cab76c62: Fix T96224: GPU subdiv crash with smooth normals and tangents (authored by Kévin Dietrich (kevindietrich)). · Explain WhyMar 8 2022, 1:47 PM

This revision was automatically updated to reflect the committed changes.

Kévin Dietrich (kevindietrich) added a commit: rBd5e4cab76c62: Fix T96224: GPU subdiv crash with smooth normals and tangents.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

intern/

draw_cache_extract_mesh.cc

1 line

Diff 49031

source/blender/draw/intern/draw_cache_extract_mesh.cc

Loading...