Page MenuHome

Preferences: Convert certain preferences to be row-based.
AbandonedPublic

Authored by Evelyn Marie (evelynmarie) on Mar 9 2022, 3:45 AM.

Details

Summary

Tweaks certain user preferences to use a row-based layout instead of a column-based layout. This includes various preferences in Viewport -> Quality, Navigation -> Orbit & Pan, and Navigation -> Zoom. To be specific, the Viewport -> Quality -> Smooth Wires, Navigation -> Orbit & Pan -> Auto, and Navigation -> Zoom -> Invert Zoom Direction preferences have been converted to use a row layout instead of the prior column-based layout. This should help cleanup the Preferences UI a little bit, as well as make it more compact. This also removes the custom text strings for the Timeout preferences under System -> Memory & Limits in favor of just using the default strings provided by the internal preference definitions.

Diff Detail

Repository
rB Blender
Branch
pref-cleanup (branched from master)
Build Status
Buildable 20947
Build 20947: arc lint + arc unit

Event Timeline

Evelyn Marie (evelynmarie) requested review of this revision.Mar 9 2022, 3:45 AM
Evelyn Marie (evelynmarie) created this revision.
Campbell Barton (campbellbarton) requested changes to this revision.Mar 9 2022, 7:29 AM

This patch doesn't apply on master, also, renaming RNA should be handled separately from layout changes.

This revision now requires changes to proceed.Mar 9 2022, 7:29 AM

@Campbell Barton (campbellbarton) I have removed the RNA changes as requested, and I have updated the revision to use the Arcanist tool instead of using a diff file. You should be able to apply this now.

I have tested this change personally, and there are no regressions. This is what the updated preferences UI looks like for anyone interested, specifically the Navigation preferences UI.

First of all, thanks for taking the time to make a patch.

This looks like it's reverting parts of rB7fc60bff14a6241c4a51cbc57b93774a90a0ea13.
These columns with headers are a standard layout element used in many places.
There is an explicit trade-off between vertical height and visual complexity, but these layouts are consistent and follow Blender's current design.
I don't think the design or layout goals have changed recently. So personally I would close this patch.

First of all, thanks for taking the time to make a patch.

This looks like it's reverting parts of rB7fc60bff14a6241c4a51cbc57b93774a90a0ea13.
These columns with headers are a standard layout element used in many places.
There is an explicit trade-off between vertical height and visual complexity, but these layouts are consistent and follow Blender's current design.
I don't think the design or layout goals have changed recently. So personally I would close this patch.

I don’t personally agree that I’m rolling back parts of that commit — that commit moved over from the old grid flow layout to columns, all I'm doing with this one is converting a few preferences from the column approach to a row-based approach to cleanup the UI, because I personally don't see it useful to have the now modified preferences be separated. It makes sense for headings with more than two preferences, but for preferences with short names and/or only two options it doesn't really make sense. That's why I only changed the couple of preferences I did, because I didn't see it useful nor beneficial to change / modify the other preferences.

You can see the row layout being used in Keymap -> Preferences, where Alt Click Tool Prompt and Alt Tool Access are next to each other.

The current layout has the advantage that similar settings are clearly linked to the header. "Invert Zoom Direction" for example work better both visually and are easier to toggle at once.

With this patch applied the buttons that aren't right next to the heading seems out of place (on their own). And while these is could be acceptable, adding additional items wont work well. Also with translations text may be cramped and not fit.

So I think the current layout can be kept.

The current layout has the advantage that similar settings are clearly linked to the header. "Invert Zoom Direction" for example work better both visually and are easier to toggle at once.

With this patch applied the buttons that aren't right next to the heading seems out of place (on their own). And while these is could be acceptable, adding additional items wont work well. Also with translations text may be cramped and not fit.

So I think the current layout can be kept.

The issue of translation text being cramped and not fitting already occurs in several other preference pages due to the default size of the preferences window, however due to your other reasons, I’ll close this patch and leave the layout as is, despite being a bit sad about it.

that commit moved over from the old grid flow layout to columns, all I'm doing with this one is converting a few preferences from the column approach to a row-based approach to cleanup the UI

That commit moved specifically to columns instead of rows because that design was discussed and chosen at the time. Among other things, it benefits organization of items, makes them easier to scan, and simplifies spacing for translations like Campbell mentioned.
Further, consistency with existing UI guidelines followed elsewhere is important.
For those reasons, I'll close this patch, like I mentioned above.

Oops, looks like I reloaded a bit too late.