Page MenuHome

Fix T45058: Cycles hair shader reflects incorrectly for meshes
ClosedPublic

Authored by Sergey Sharybin (sergey) on Jul 21 2015, 2:55 PM.

Details

Summary

The issue was caused by non-continuous tangent space calculated for triangles.

This commit adds a Tangent input to Hair BSDF node which can be used to hook up
Tangent calculated form UV as an input to the node in order to make sure the
tangent space is continuous.

Doing this as an input instead of using default tangent layer from UV because of
several reasons:

  • This way it's really easy to preserve compatibility with existing setups.
  • Default UV map is not necessarily giving continuous space, one might want to use other tangent space sources or distort the space for some artistic decision.

Diff Detail

Repository
rB Blender

Event Timeline

Sergey Sharybin (sergey) retitled this revision from to Fix T45058: Cycles hair shader reflects incorrectly for meshes.
Sergey Sharybin (sergey) updated this object.
Thomas Dinges (dingto) edited edge metadata.

Code looks good to me.

This revision is now accepted and ready to land.Jul 23 2015, 12:19 AM
This revision was automatically updated to reflect the committed changes.