Curves: Move constructor/assignment
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Mar 10 2022, 6:33 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)

Commits

rB22807d2075b0: Curves: Move constructor/assignment

Summary

Add the ability to move CurvesGeometry without copying its attributes and data.
The source is left in an empty but valid state. A test file is added to test the move
constructor.

Diff Detail

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Mar 10 2022, 6:33 PM

Hans Goudey (HooglyBoogly) created this revision.

Fix state of source after move

Jacques Lucke (JacquesLucke) added inline comments.Mar 10 2022, 8:52 PM

source/blender/blenkernel/intern/curves_geometry.cc
91	we just do a shallow swap of the entire `CurvesGeometry` instead of swapping the individual elements?

Use std::swap on the whole struct rather than individual members

Jacques Lucke (JacquesLucke) requested changes to this revision.Mar 11 2022, 1:06 PM

Jacques Lucke (JacquesLucke) added inline comments.

source/blender/blenkernel/intern/curves_geometry.cc
90	This calls the move operations internally, so it results in a stack overflow (P2830).
source/blender/blenkernel/intern/curves_geometry_test.cc
40	I'm 95% sure that you didn't run this test yet, because it's not crashing for you. The reason might be that that `CurvesGeometryTest` is missing an `s` in the end.