Page MenuHome
Differential D14304

Geometry Nodes: improve texture sampler code
Needs ReviewPublic
Actions

Authored by Ethan Hall (Ethan1080) on Mar 10 2022, 11:45 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Summary

The changes made in this patch are analogous to the changes made in
this Cycles patch: D14295 | rB4abb8a14a213.

This patch brings minor performance improvements, code consistency,
and also, helps cleanup to prepare for future features.

Future Features I Want to Implement:

  • Independent axis extensions for X/U and Y/V
  • Mirrored repeat texture extension mode

Here is a test file for verification purposes:

Image Texture Node Comparison.blend94 KBDownload

Diff Detail

Repository
rB Blender
Branch
geonode_tex_sampler_refactor (branched from master)
Build Status
Buildable 20980
Build 20980: arc lint + arc unit

Event Timeline

Ethan Hall (Ethan1080) requested review of this revision.Mar 10 2022, 11:45 PM
Ethan Hall (Ethan1080) created this revision.
Harbormaster completed remote builds in B20980: Diff 49153.Mar 10 2022, 11:45 PM
Ethan Hall (Ethan1080) edited the summary of this revision. (Show Details)Mar 11 2022, 12:04 AM
Ethan Hall (Ethan1080) added a project: Geometry Nodes.
Ethan Hall (Ethan1080) added subscribers: Jacques Lucke (JacquesLucke), Ray Molenkamp (LazyDodo).
Ethan Hall (Ethan1080) edited the summary of this revision. (Show Details)Mar 11 2022, 12:06 AM
Ethan Hall (Ethan1080) mentioned this in D14237: (WIP) Shader/Geometry Nodes: Enabled image texture extensions to be set independently for X/U and Y/V axes.Mar 11 2022, 12:13 AM
Ethan Hall (Ethan1080) edited the summary of this revision. (Show Details)Mar 12 2022, 12:50 AM
Ethan Hall (Ethan1080) updated this revision to Diff 49234.Mar 14 2022, 5:46 AM
  • Fixed some of the issues with the patch.
Harbormaster completed remote builds in B21016: Diff 49234.Mar 14 2022, 5:46 AM
Ethan Hall (Ethan1080) edited the summary of this revision. (Show Details)Mar 14 2022, 5:51 AM
Jacques Lucke (JacquesLucke) added a comment.Mar 14 2022, 10:56 AM

Is this ready for review, if yes, please add me as reviewer. Otherwise maybe add (WIP) to the title.

Ethan Hall (Ethan1080) edited the summary of this revision. (Show Details)Mar 14 2022, 8:12 PM
Ethan Hall (Ethan1080) retitled this revision from Geometry Nodes: Refactored parts of the texture sampler code to simplify and support further feature development to WIPGeometry Nodes: Refactored parts of the texture sampler code to simplify and support further feature development.
Ethan Hall (Ethan1080) retitled this revision from WIPGeometry Nodes: Refactored parts of the texture sampler code to simplify and support further feature development to (WIP) Geometry Nodes: Refactored parts of the texture sampler code to simplify and support further feature development.
Ethan Hall (Ethan1080) added a comment.Mar 14 2022, 8:22 PM

@Jacques Lucke (JacquesLucke) I will wait until I do more testing and/or until my Cycles patch is accepted before adding you as reviewer.

Ethan Hall (Ethan1080) updated this revision to Diff 49281.Mar 15 2022, 1:09 PM
  • Fix edge clip bounds for closest interpolation.
Harbormaster completed remote builds in B21043: Diff 49281.Mar 15 2022, 1:09 PM
Ethan Hall (Ethan1080) updated this revision to Diff 49288.Mar 15 2022, 2:35 PM
  • Changed order of image_pixel_lookup_clip conditional evaluation.
Harbormaster completed remote builds in B21047: Diff 49288.Mar 15 2022, 2:35 PM
Ethan Hall (Ethan1080) updated this revision to Diff 49320.EditedMar 16 2022, 1:16 AM
  • Used integer comparison for closest clip bounds.
Harbormaster completed remote builds in B21056: Diff 49320.Mar 16 2022, 1:16 AM
Ethan Hall (Ethan1080) updated this revision to Diff 50844.Apr 26 2022, 4:44 PM
  • Increased the similarity with the new Cycles code
Harbormaster completed remote builds in B21818: Diff 50844.Apr 26 2022, 4:44 PM
Ethan Hall (Ethan1080) retitled this revision from (WIP) Geometry Nodes: Refactored parts of the texture sampler code to simplify and support further feature development to Geometry Nodes: improve texture sampler code.Apr 26 2022, 4:55 PM
Ethan Hall (Ethan1080) edited the summary of this revision. (Show Details)
Ethan Hall (Ethan1080) added a reviewer: Jacques Lucke (JacquesLucke).
Emi Martinez (EmiMartinez) added a subscriber: Emi Martinez (EmiMartinez).Aug 16 2022, 3:35 AM

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
geometry/
nodes/
83 lines

Diff 49153

View Options

source/blender/nodes/geometry/nodes/node_geo_image_texture.cc

Loading...