Fix T85689: Replace SHGetFileInfoW for Drive Name
ClosedPublic
Actions

Authored by Harley Acheson (harley) on Mar 11 2022, 2:38 AM.

Details

Reviewers

Brecht Van Lommel (brecht)
Ray Molenkamp (LazyDodo)

Commits

rBae3c8bc9f098: Fix T85689: Replace SHGetFileInfoW for Drive Name

Summary

Win32: Replace SHGetFileInfoW as means to get friendly display names
for volumes because it causes long pauses for disconnected remote
drives.

We currently use SHGetFileInfoW on the Win32 platform to get friendly display names for volumes. Unfortunately this function can result in long pauses for slow or unresponsive network mounts.

This behavior reported in T85689 was for disconnected network share (server turned off) and was confirmed by @Ray Molenkamp (LazyDodo), and then he wrote this solution inspired by identical problem and similar solution by glib as a response to https://gitlab.gnome.org/GNOME/glib/-/issues/2096

Diff Detail

Repository: rB Blender

Event Timeline

Harley Acheson (harley) requested review of this revision.Mar 11 2022, 2:38 AM

Harley Acheson (harley) created this revision.

it's not pretty, but unless we move this file to C++ I don't see a nicer way, COM and C will never be good looking friends.

I'd like to point out that the behavior of SHGetFileInfoW was expected behavior, not a bug, the msdn docs warns You should call this function from a background thread. Failure to do so could cause the UI to stop responding.

This revision is now accepted and ready to land.Mar 11 2022, 3:15 AM

Brecht Van Lommel (brecht) accepted this revision.Mar 11 2022, 12:55 PM

Closed by commit rBae3c8bc9f098: Fix T85689: Replace SHGetFileInfoW for Drive Name (authored by Harley Acheson (harley)). · Explain WhyMar 11 2022, 6:27 PM

This revision was automatically updated to reflect the committed changes.

Harley Acheson (harley) added a commit: rBae3c8bc9f098: Fix T85689: Replace SHGetFileInfoW for Drive Name.

Harley Acheson (harley) mentioned this in D14506: Fix T85689: Assume Win32 Volumes are Valid.Mar 30 2022, 7:01 PM