Page MenuHome
Differential D14310

VSE: Use edge panning
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Mar 11 2022, 12:51 PM.

Details

Reviewers
Julian Eisel (Severin)
Commits
rBe49fef45cef7: VSE: Use edge panning
Summary

Add edge panning feature to transform operator. It works in same way as
in node editor, but Y axis is limited by usable range up to 128
channels.

Diff Detail

Repository
rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.Mar 11 2022, 12:51 PM
Richard Antalik (ISS) created this revision.
Harbormaster completed remote builds in B20982: Diff 49163.Mar 11 2022, 12:51 PM
Richard Antalik (ISS) mentioned this in D14263: VSE: Limit timeline view height.Mar 11 2022, 3:28 PM
Julian Eisel (Severin) requested changes to this revision.Mar 11 2022, 5:14 PM

Seems fine mostly. Just one thing I noticed is that the speed is too high to control the transform nicely. Especially when zoomed in. In the node editor it feels like I have much more control whereas in the VSE it scrolls very fast very early. That's the only behavior change I'd suggest.

source/blender/editors/transform/transform_convert_sequencer.c
648–651

Other code only sets this based on CTX_VIEW2D_EDGE_PAN here: https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/transform/transform_generics.c$673-676
What's the reason behind this special case?

736

This is also something that the node editor doesn't seem to do. Could you explain why this is needed? Best in a code comment.

This revision now requires changes to proceed.Mar 11 2022, 5:14 PM
Richard Antalik (ISS) updated this revision to Diff 49175.Mar 11 2022, 5:43 PM
Richard Antalik (ISS) marked 2 inline comments as done.
  • address inlines
Harbormaster completed remote builds in B20991: Diff 49175.Mar 11 2022, 5:43 PM
Richard Antalik (ISS) added inline comments.Mar 11 2022, 5:44 PM
source/blender/editors/transform/transform_convert_sequencer.c
648–651

I think I have copied this from original diff.

736

They do here https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/transform/transform_convert_node.c$155-186

I wanted to extract specific math to own function, but shouldn't include edge pan handling there, so fixed that.

Richard Antalik (ISS) updated this revision to Diff 49176.Mar 11 2022, 5:45 PM
  • Decrease panning speed
Harbormaster completed remote builds in B20992: Diff 49176.Mar 11 2022, 5:45 PM
Julian Eisel (Severin) accepted this revision.Mar 11 2022, 8:32 PM

I still find it a bit too sensitive & fast, a SEQ_EDGE_PAN_SPEED_RAMP of 3 or even 4 works quite nice for me.

I'd still suggest to change that, otherwise looking ready to me.

This revision is now accepted and ready to land.Mar 11 2022, 8:32 PM
Richard Antalik (ISS) updated this revision to Diff 49266.Mar 14 2022, 10:02 PM
  • Change edgepan speed
Harbormaster completed remote builds in B21033: Diff 49266.Mar 14 2022, 10:02 PM
Richard Antalik (ISS) updated this revision to Diff 49808.Mar 29 2022, 1:04 AM

Rebase

Harbormaster completed remote builds in B21298: Diff 49808.Mar 29 2022, 1:04 AM
Closed by commit rBe49fef45cef7: VSE: Use edge panning (authored by Richard Antalik (ISS)). · Explain WhyApr 4 2022, 2:33 PM
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) added a commit: rBe49fef45cef7: VSE: Use edge panning.

Revision Contents
Changeset List

PathSize
release/
scripts/
presets/
keyconfig/
keymap_data/
8 lines
source/
blender/
editors/
include/
8 lines
interface/
18 lines
transform/
57 lines
2 lines

Diff 50075

View Options

release/scripts/presets/keyconfig/keymap_data/blender_default.py

Loading...
View Options

source/blender/editors/include/UI_view2d.h

Loading...
View Options

source/blender/editors/interface/view2d_edge_pan.cc

Loading...
View Options

source/blender/editors/transform/transform_convert_sequencer.c

Loading...
View Options

source/blender/editors/transform/transform_ops.c

Loading...