Differential D14311

Fix T96229: GN Fillet Node unexpected limit radius behavior for 3 point splines
ClosedPublic
Actions

Authored by Dilith Jayakody (dilithjay) on Mar 11 2022, 2:18 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T96229: GN Fillet Curves does not respect radius when Limit Radius is checked and curve only has 3 points

Commits

rB39c070ed8f7f: Fix T96229: GN Fillet Node unexpected limit radius behavior for 3 point splines

Summary

This commit fixes T96229.

The maximum possible radius was being used for 3 point
splines, regardless of the current radius.

Diff Detail

Repository

rB Blender

Branch

gn-fillet-fix (branched from master)

Build Status

Buildable 20983
Build 20983: arc lint + arc unit

Event Timeline

Dilith Jayakody (dilithjay) requested review of this revision.Mar 11 2022, 2:18 PM

Dilith Jayakody (dilithjay) created this revision.

Harbormaster completed remote builds in B20983: Diff 49164.Mar 11 2022, 2:18 PM

Hans Goudey (HooglyBoogly) accepted this revision.Mar 11 2022, 9:02 PM

This revision is now accepted and ready to land.Mar 11 2022, 9:02 PM

Closed by commit rB39c070ed8f7f: Fix T96229: GN Fillet Node unexpected limit radius behavior for 3 point splines (authored by Dilith Jayakody (dilithjay)). · Explain WhyMar 12 2022, 5:51 AM

This revision was automatically updated to reflect the committed changes.

Dilith Jayakody (dilithjay) added a commit: rB39c070ed8f7f: Fix T96229: GN Fillet Node unexpected limit radius behavior for 3 point splines.

Revision Contents
Changeset List

Path

Size

source/

blender/

nodes/

geometry/

nodes/

node_geo_curve_fillet.cc

2 lines

Diff 49164

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_fillet.cc

Fix T96229: GN Fillet Node unexpected limit radius behavior for 3 point splinesClosedPublicActions