Paths

Table of Contentst

Differential D14315

Validation message split from nurb_check_valid
ClosedPublic
Actions

Authored by Laurynas Duburas (laurynas) on Mar 11 2022, 7:48 PM.

Tags

None

Subscribers

None

Details

Reviewers

Hans Goudey (HooglyBoogly)
Campbell Barton (campbellbarton)

Commits

rB6bbc3b561081: Curve: Validation message split from nurb_check_valid

Diff Detail

Repository: rB Blender

Event Timeline

Laurynas Duburas (laurynas) requested review of this revision.Mar 11 2022, 7:48 PM

Laurynas Duburas (laurynas) created this revision.

Harbormaster completed remote builds in B20994: Diff 49188.Mar 11 2022, 7:48 PM

Thanks for making the patch. I'll move my comments here too.
I like the idea of separating the error message from finding an error.

Use an enum class for the error values. It would be cleaner to add an explicit "None" value to the enum instead of using zero.
Indeed, TIP_ needs to run at runtime. A function with a switch case instead of the VALID_MESSAGES should be used to retrieve the messages. This also doesn't rely on indices being the same.

source/blender/blenkernel/intern/curve.cc
4787–4790	Unless there's a specific reason to use a 16 bit unsigned integer, the style guide prefers sticking with `int`.

This revision now requires changes to proceed.Mar 11 2022, 8:53 PM

NURBSValidationStatus enum added
Exception added in BKE_nurb_valid_message for pntsv == 1. Now BKE_nurb_valid_message is not equivalent to nurb_check_valid

Harbormaster completed remote builds in B20995: Diff 49193.Mar 11 2022, 9:28 PM

Laurynas Duburas (laurynas) mentioned this in rBd2222d5b2cac: RNA: use a function to access the nurbs error message.Mar 11 2022, 9:32 PM

Looks good, thanks.

Accepting, noting minor changes.

source/blender/blenkernel/intern/curve.cc
4716	Return args should use `r_` prefix.
4757–4778	This can be `NULL`.

This revision is now accepted and ready to land.Mar 14 2022, 11:30 AM

Minor changes

Harbormaster completed remote builds in B21021: Diff 49243.Mar 14 2022, 12:47 PM

Closed by commit rB6bbc3b561081: Curve: Validation message split from nurb_check_valid (authored by Laurynas Duburas (laurynas), committed by Hans Goudey (HooglyBoogly)). · Explain WhyMar 22 2022, 3:54 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB6bbc3b561081: Curve: Validation message split from nurb_check_valid.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

2 lines

intern/

92 lines

makesrna/

intern/

rna_curve_api.c

5 lines

Diff 49545

source/blender/blenkernel/BKE_curve.h

Loading...

source/blender/blenkernel/intern/curve.cc

Loading...

source/blender/makesrna/intern/rna_curve_api.c

Loading...