Page MenuHome
Differential D1432

BGE: Change KX_WolrdInfo mathutils vector to color
ClosedPublic
Actions

Authored by Thomas Szepe (hg1) on Jul 26 2015, 4:23 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Sybren A. Stüvel (sybren)
Porteries Tristan (panzergame)
Jorge Bernal (lordloki)
Mitchell Stokes (moguri)
Commits
rBSbd6febc4c4fa: BGE: Change KX_WolrdInfo mathutils vector to color
rBbd6febc4c4fa: BGE: Change KX_WolrdInfo mathutils vector to color
Summary

Change the mathutils callback from vector to color for mistColor, backgroundColor and ambientColor.

Diff Detail

Event Timeline

Thomas Szepe (hg1) updated this revision to Diff 4750.Jul 26 2015, 4:23 PM
Thomas Szepe (hg1) retitled this revision from to BGE: Change KX_WolrdInfo mathutils vector to color.
Thomas Szepe (hg1) updated this object.
Thomas Szepe (hg1) added reviewers: Mitchell Stokes (moguri), Porteries Tristan (panzergame), Sybren A. Stüvel (sybren), Jorge Bernal (lordloki).
Thomas Szepe (hg1) added projects: Game Engine, Game Logic.
Mitchell Stokes (moguri) accepted this revision.Jul 26 2015, 9:44 PM
Mitchell Stokes (moguri) added a reviewer: Campbell Barton (campbellbarton).
Mitchell Stokes (moguri) edited edge metadata.

Looks good to me.

This revision is now accepted and ready to land.Jul 26 2015, 9:45 PM
Porteries Tristan (panzergame) edited edge metadata.Jul 26 2015, 9:48 PM

it looks good to me. I not tested : i trust you.

Porteries Tristan (panzergame) accepted this revision.Jul 26 2015, 9:50 PM
Porteries Tristan (panzergame) edited edge metadata.
Sybren A. Stüvel (sybren) requested changes to this revision.Jul 27 2015, 3:58 PM
Sybren A. Stüvel (sybren) edited edge metadata.

Please include a sample blend file that demonstrates the new functionality, including setting a new color object (like world.backgroundColor = some_color) and showing whether setting a single component works (like world.backgroundColor.r = 0.34). This is needed for the release log anyway, makes it much easier for us to test, and serves as future documentation.

This revision now requires changes to proceed.Jul 27 2015, 3:58 PM
Thomas Szepe (hg1) added a comment.Jul 27 2015, 5:01 PM

What do you mean with "release log"? Did you mean the "release note" http://wiki.blender.org/index.php/Dev:Ref/Release_Notes/2.75?

As I know we only need a sample blend file for new features. But this is only a little API change.
Also I think for a missing test file you don't need make a patch stopping "request changes". A simple comment should be enough.

Anyway here is my test file.

Mist4.blend117 KBDownload

Thomas Szepe (hg1) updated this revision to Diff 4754.Jul 27 2015, 5:01 PM
Thomas Szepe (hg1) edited edge metadata.
  • Add missing KX_WorldInfo.rst documentation changes.
Sybren A. Stüvel (sybren) accepted this revision.Jul 27 2015, 5:43 PM
Sybren A. Stüvel (sybren) edited edge metadata.
In D1432#29945, @Thomas Szepe (hg1) wrote:

What do you mean with "release log"? Did you mean the "release note" http://wiki.blender.org/index.php/Dev:Ref/Release_Notes/2.75?

Yup, that.

As I know we only need a sample blend file for new features. But this is only a little API change.

True that. It was only partially because of the release notes that I asked for it. In my experience an example file helps a lot when testing changes, as it shows more about the ideas of the programmer when (s)he made the changes.

Thanks for the test file, it's really extensive :)

This revision is now accepted and ready to land.Jul 27 2015, 5:43 PM
Closed by commit rBbd6febc4c4fa: BGE: Change KX_WolrdInfo mathutils vector to color (authored by Thomas Szepe (hg1)). · Explain WhyOct 11 2015, 6:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
doc/
python_api/
rst/
bge_types/
6 lines
source/
gameengine/
Ketsji/
70 lines

Diff 4754

View Options

doc/python_api/rst/bge_types/bge.types.KX_WorldInfo.rst

Loading...
View Options

source/gameengine/Ketsji/KX_WorldInfo.cpp

Loading...