Fix T96157: Frame Node Labelsize changing depending on line-width setting
ClosedPublic
Actions

Authored by Dominik Fill (dominikfill) on Mar 14 2022, 5:58 PM.

Details

Reviewers

Harley Acheson (harley)
Julian Eisel (Severin)

Maniphest Tasks

T96157: Changing the line width settings drastically affects the font size of frame labels

Commits

rBf523fb1dc9bb: Fix T96157: Make size of Frame Node label independent from Line Width
rBc8cef83faece: Fix T96157: Make size of Frame Node label independent from Line Width

Summary

Fix similar to the fix in https://developer.blender.org/D14322

Corrects the calculation of the Frame Node label size, making it independent of the line-width user setting.

U.dpi is actually DPI divided by U.pixelsize, and U.pixelsize is calculated from line-width. Multiplying by U.pixelsize breaks the connection between line-width and labelsize, labelsize stays the same now, regardless of the line-width setting.

Diff Detail

Repository: rB Blender

Event Timeline

Dominik Fill (dominikfill) requested review of this revision.Mar 14 2022, 5:58 PM

Dominik Fill (dominikfill) created this revision.

Harbormaster completed remote builds in B21030: Diff 49258.Mar 14 2022, 5:58 PM

Dominik Fill (dominikfill) changed the visibility from "Public (No Login Required)" to "No One".Mar 14 2022, 5:59 PM

Dominik Fill (dominikfill) retitled this revision from Multiply BLF_size size parameter by U.pixelsize to Fix T96157: Frame Node Labelsize changing depending on line-width setting.Mar 14 2022, 6:06 PM

Dominik Fill (dominikfill) edited the summary of this revision. (Show Details)

Dominik Fill (dominikfill) changed the visibility from "No One" to "Public (No Login Required)".

Dominik Fill (dominikfill) added a project: User Interface.

Dominik Fill (dominikfill) mentioned this in T96157: Changing the line width settings drastically affects the font size of frame labels.Mar 14 2022, 6:11 PM

Hans Goudey (HooglyBoogly) added a reviewer: Harley Acheson (harley).Mar 14 2022, 7:04 PM

Leon Schittek (lone_noel) awarded a token.Mar 15 2022, 7:19 AM

Leon Schittek (lone_noel) mentioned this in D13954: Fix T95105: Unclamp draw size of the frame node's label.Mar 19 2022, 1:08 PM

Thanks for the patch! I thoroughly tested it and for such a small change it's a pretty big improvement overall.
Not only is the label size now consistent regardless of the line width, it's also more consistent across different dpi displays or UI scales.

@Harley Acheson (harley) Not sure if it's up to me to accept this, but if this patch has your blessing, I could take care of committing it.

Test matrix Line Width and dpi
Notice how in master the label size varies both with different line width values and between the 1080p and higher dpi display.
Both is fixed with this patch.

	master, 1080p	master, retina	patch, 1080p	patch, retina
thin
default
thick

Test matrix UI Scale
In master the label size stays fixed in screen space, but with the patch it properly scales together with the rest of the UI which is more expected, I think.