Page MenuHome
Differential D14344

User Pref: Improve consistency and clarity of names and tooltips
ClosedPublic
Actions

Authored by Ethan Hall (Ethan1080) on Mar 15 2022, 12:13 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rBf8d19ec5a3d8: UI: improve names and tooltips in viewport preferences
Summary

I renamed "OpenGL Depth Picking" to "GPU Depth Picking" so the UI text for the option is not specific to the graphics API.

I changed the tooltip for OpenGL Depth Picking from "Use the depth buffer for picking 3D View selection (without this the front most object may not be selected first)" to "When making a selection in 3D View, use the GPU depth buffer to ensure the frontmost object is selected first"

In Viewport > Display. I changed "Show" to "Text Info Overlay" since the options only "show" when the text info overlay is enabled.

I made capitalization consistent in places and reworked a few other labels and tooltips.

Let me know if I should revert or tweak any change.

With this patch, I did not change anything in the animation tab of the preferences, but it could also use some similar improvements.

Diff Detail

Repository
rB Blender

Event Timeline

Ethan Hall (Ethan1080) requested review of this revision.Mar 15 2022, 12:13 AM
Ethan Hall (Ethan1080) created this revision.
Harbormaster completed remote builds in B21034: Diff 49268.Mar 15 2022, 12:13 AM
Ethan Hall (Ethan1080) edited the summary of this revision. (Show Details)Mar 15 2022, 12:26 AM
Ethan Hall (Ethan1080) added projects: User Interface, EEVEE & Viewport.
Ethan Hall (Ethan1080) added a subscriber: Hans Goudey (HooglyBoogly).
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).Mar 15 2022, 12:34 AM

I don't think moving this to System is better. There are more quality/performance related settings in the Viewport tab, and I think these belong in the same place.

The name and description changes are fine.

Hans Goudey (HooglyBoogly) added a comment.Mar 15 2022, 1:39 AM

I don't have a strong opinion about the preferences, the reasoning doesn't seem strong enough to change it though.

source/blender/makesrna/intern/rna_userdef.c
5654

While you're at it, I think frontmost is the correct spelling (https://books.google.com/ngrams/graph?content=frontmost%2C+front+most&year_start=1800&year_end=2019&corpus=26&smoothing=3&direct_url=t1%3B%2Cfrontmost%3B%2Cc0%3B.t1%3B%2Cfront%20most%3B%2Cc0),

Ethan Hall (Ethan1080) updated this revision to Diff 49277.Mar 15 2022, 8:10 AM
  • Reverted moving settings.
  • Tweaked UI labels and tooltips for consistency and clarity.
Harbormaster completed remote builds in B21039: Diff 49277.Mar 15 2022, 8:10 AM
Ethan Hall (Ethan1080) retitled this revision from User Pref: Moved OpenGL Depth Picking and GPU Subdivision from Viewport to System > Viewport to User Pref: Improve consistency and clarity of names and tooltips.Mar 15 2022, 8:32 AM
Ethan Hall (Ethan1080) edited the summary of this revision. (Show Details)
RedMser (RedMser) added a subscriber: RedMser (RedMser).Mar 15 2022, 12:33 PM
RedMser (RedMser) added inline comments.
release/scripts/startup/bl_ui/space_userpref.py
694

Correct me if I'm wrong, but since the RNA property labels are now the same as those used in the UI here, there's no need to specify them inline with text="..." here anymore.

Hans Goudey (HooglyBoogly) added a comment.Mar 15 2022, 2:58 PM

A couple inline comments, but I think the changes here are generally improvements

release/scripts/startup/bl_ui/space_userpref.py
691–692

The idea with the headings is to avoid repeating this text like "Include".
I think "Show" or "Include" is implied here, and could be removed from this UI text.

source/blender/makesrna/intern/rna_userdef.c
4592–4613

In the 3D viewport text info overlay

I guess it could be helpful when looking at the property in Python without the UI, but in the preferences, the panel name and header provide this context, so I don't think it's necessary.

Brecht Van Lommel (brecht) requested changes to this revision.Mar 15 2022, 3:08 PM
Brecht Van Lommel (brecht) added inline comments.
release/scripts/startup/bl_ui/space_userpref.py
701

This change seems arbitrary, no good reason to break docs/tutorials.

source/blender/makesrna/intern/rna_userdef.c
5023

"Object" should not be left out here, names here can't assume their context in the preferences.

5652–5654

I don't thinking "Depth Sorting" is a better name, it can be confused with alpha sorting.

This revision now requires changes to proceed.Mar 15 2022, 3:08 PM
Ethan Hall (Ethan1080) updated this revision to Diff 49294.Mar 15 2022, 4:34 PM
Ethan Hall (Ethan1080) edited the summary of this revision. (Show Details)
  • Applied suggested tweaks.
Harbormaster completed remote builds in B21049: Diff 49294.Mar 15 2022, 4:34 PM
Ethan Hall (Ethan1080) edited the summary of this revision. (Show Details)Mar 15 2022, 4:35 PM
Ethan Hall (Ethan1080) marked 6 inline comments as done.Mar 15 2022, 4:38 PM
Ethan Hall (Ethan1080) updated this revision to Diff 49295.Mar 15 2022, 4:47 PM
  • Reworded text info overlay related tooltips.
Harbormaster completed remote builds in B21050: Diff 49295.Mar 15 2022, 4:47 PM
Ethan Hall (Ethan1080) added inline comments.Mar 15 2022, 4:55 PM
source/blender/makesrna/intern/rna_userdef.c
4592–4613

"3D viewport" can easily be omitted, but I prefer that the sentence mentions where it is including the item.

Brecht Van Lommel (brecht) added inline comments.Mar 15 2022, 5:54 PM
source/blender/makesrna/intern/rna_userdef.c
4591

Keep this as Display instead of Include, for consistency with other similar properties.

Ethan Hall (Ethan1080) updated this revision to Diff 49317.Mar 16 2022, 12:45 AM
  • Changed "Include" to "Display" for RNA label consistency.
Harbormaster completed remote builds in B21055: Diff 49317.Mar 16 2022, 12:45 AM
Ethan Hall (Ethan1080) marked 2 inline comments as done.Mar 17 2022, 4:31 PM
Brecht Van Lommel (brecht) accepted this revision.Mar 21 2022, 6:07 PM
This revision is now accepted and ready to land.Mar 21 2022, 6:07 PM
Closed by commit rBf8d19ec5a3d8: UI: improve names and tooltips in viewport preferences (authored by Ethan Hall (Ethan1080), committed by Brecht Van Lommel (brecht)). · Explain WhyMar 21 2022, 6:44 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rBf8d19ec5a3d8: UI: improve names and tooltips in viewport preferences.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
4 lines
source/
blender/
makesrna/
intern/
64 lines

Diff 49495

View Options

release/scripts/startup/bl_ui/space_userpref.py

Loading...
View Options

source/blender/makesrna/intern/rna_userdef.c

Loading...