Page MenuHome

Fix T96476: Equalize Handles Operator not working on all selected keyframes
ClosedPublic

Authored by Kevin C. Burke (blastframe) on Mar 15 2022, 3:22 AM.

Details

Summary

As the default handle type in Blender is 'Auto Clamped' the Equalize Handles operator will often appear to have no affect on the selected keyframes on which it is run. If either of the keyframes' handle types are 'Auto', 'Auto Clamped', or 'Vector', this patch will convert the handles to 'Aligned'.

More info about this Issue in this bug: T96476

Diff Detail

Repository
rB Blender

Event Timeline

Rather than just changing the description, Equalize Handles now changes the Handle Type to 'Free'. As the default handle type in Blender is 'Auto Clamped', Equalize Handles will have no affect when the operator is run.

Kevin C. Burke (blastframe) retitled this revision from Temporary Fix T96476: Equalize Handles Operator not working on all selected keyframes to Fix T96476: Equalize Handles Operator not working on all selected keyframes.
Kevin C. Burke (blastframe) edited the summary of this revision. (Show Details)
Kevin C. Burke (blastframe) edited the summary of this revision. (Show Details)

Please follow style guide for comments (capitalize first letter and end with fullstop) https://wiki.blender.org/wiki/Style_Guide/C_Cpp#Comments

I don't animate as much to tell whether this is good change or not, but I would expect handles to be converted to Aligned since these are default for handles?

I updated the comments to follow the style guide, thank you.

I thought 'Auto-Clamped' was the default handle type unless it was imported with one of my previous Blender version's preferences.

Either 'Free' or 'Aligned' work with the Equalize Handles operator, but perhaps you're right that 'Aligned' would be a better choice here as I think breaking the handles with 'Free' should be the user's choice. Thanks for the suggestion!

My bad, auto clamped is default, unless you move handle manually, then it becomes aligned.

Sybren A. Stüvel (sybren) requested changes to this revision.Apr 8 2022, 3:23 PM

The code doesn't follow the patch description. The description says it sets the type to "Free", but the code sets it to "Aligned". Furthermore, the description mentions that the operator won't work with "Auto-Clamped", but it also changes the handle type when set to "Auto" or "Vector".

The description of the GRAPH_OT_equalize_handles operator should also be expanded to communicate the potential change in handle type.

This revision now requires changes to proceed.Apr 8 2022, 3:23 PM

Added Operator description describing handle conversion. Now converting both handles to 'Aligned' as mismatching handles produced undesired results with handle angles.

  • Fix operator description
source/blender/editors/space_graph/graph_edit.c
2402–2403

have have :) Nice to see such an old "optical trick" actually in the wild :) I'll fix that when I land the patch.

This revision is now accepted and ready to land.Apr 28 2022, 11:14 AM