Page MenuHome

Fix T63795: Display custom properties with brackets in info.
ClosedPublic

Authored by Yuki Hashimoto (hzuika) on Mar 18 2022, 6:58 PM.

Details

Summary

When custom properties are changed, they are displayed with brackets in info.

This modification refers to RNA_path_from_ID_to_property_index.


Bug

Fix

Diff Detail

Repository
rB Blender
Branch
T63795 (branched from master)
Build Status
Buildable 21102
Build 21102: arc lint + arc unit

Event Timeline

Yuki Hashimoto (hzuika) requested review of this revision.Mar 18 2022, 6:58 PM
Yuki Hashimoto (hzuika) created this revision.

I applied clang format.

Campbell Barton (campbellbarton) requested changes to this revision.Mar 29 2022, 8:08 AM

This works well, only minor issues noted inline.

source/blender/windowmanager/intern/wm_operators.c
591

This passes a character as '.' as a string.

instead of many string formatting characters, prefer:

BLI_string_join(member_id, ".", data_path, prop_str) since nothing is gained from using string formatting and join is used elsewhere in this function.

Same goes for BLI_sprintfN use below.

This revision now requires changes to proceed.Mar 29 2022, 8:08 AM
source/blender/makesrna/intern/rna_access.c
6019

*picky* prefer to assign on declaration.

  • assign on declaration.
  • use BLI_string_joinN and BLI_strdup instead of BLI_sprintfN
This revision is now accepted and ready to land.Mar 29 2022, 3:28 PM