Details

Reviewers

Campbell Barton (campbellbarton)
Bastien Montagne (mont29)

Commits

rB35f34a3cf840: Modifiers: Support applying modifiers for multi-user data
rB218bcff32db5: Iterator to loop over objects based on a flag

Summary

The current behaviour is to prevent multi-user data from having its
modifier applied.

Instead, with this patch, we now warn the user that if they want to
proceed the object will be made single-user.

Note that this only makes the object data single-user. Not the material or actions.

As a future step we can apply the same behaviour for the Grease Pencil modifiers.

Diff Detail

Repository

rB Blender

Branch

apply-modifier (branched from master)

Build Status

Buildable 21354
Build 21354: arc lint + arc unit

Event Timeline

Dalai Felinto (dfelinto) requested review of this revision.Mar 18 2022, 7:59 PM

Dalai Felinto (dfelinto) created this revision.

Harbormaster completed remote builds in B21104: Diff 49411.Mar 18 2022, 7:59 PM

Matej Junk (MJunk) awarded a token.Mar 19 2022, 6:07 AM

Copies the logic from D14377

Harbormaster completed remote builds in B21184: Diff 49556.Mar 22 2022, 7:24 PM

Rebasing with master after latest C++ cleanup fixes

Harbormaster completed remote builds in B21223: Diff 49644.Mar 24 2022, 11:17 AM

Support parented active object

It still needs to support when the children are parented.

Harbormaster completed remote builds in B21232: Diff 49663.Mar 24 2022, 4:50 PM

Cleanup, working for all transforms and parent, ready for final review

Harbormaster completed remote builds in B21233: Diff 49671.Mar 24 2022, 7:12 PM

Dalai Felinto (dfelinto) retitled this revision from Apply Scale: multi-user data support (WIP) to Apply Object Transform: Multi-user data support.Mar 24 2022, 7:13 PM

Dalai Felinto (dfelinto) edited the summary of this revision. (Show Details)

Account for active object not being selected.

Harbormaster completed remote builds in B21235: Diff 49673.Mar 24 2022, 7:22 PM

Fix parentinv

Harbormaster completed remote builds in B21251: Diff 49712.Mar 25 2022, 4:15 PM

Dalai Felinto (dfelinto) edited the summary of this revision. (Show Details)Mar 25 2022, 4:20 PM

Fix C++

Harbormaster completed remote builds in B21252: Diff 49715.Mar 25 2022, 4:29 PM

Wilsimar (wilBr) awarded a token.Mar 25 2022, 6:45 PM

It seems this patch has been mixed up with D14377, I've submitted a review to this patch there.

Riccardo Fasoli (fasoric) awarded a token.Mar 27 2022, 6:46 PM

Dalai Felinto (dfelinto) retitled this revision from Apply Object Transform: Multi-user data support to Modifiers: Support applying modifiers for multi-user data.Mar 28 2022, 10:59 AM

Dalai Felinto (dfelinto) edited the summary of this revision. (Show Details)

Dalai Felinto (dfelinto) mentioned this in D14377: Apply Object Transform: Multi-user data support.

Upload the correct patch

Harbormaster completed remote builds in B21270: Diff 49764.Mar 28 2022, 11:00 AM

From review: Add comment in the iterator

Harbormaster completed remote builds in B21274: Diff 49768.Mar 28 2022, 12:04 PM

wrong update

Harbormaster completed remote builds in B21275: Diff 49769.Mar 28 2022, 12:22 PM

Re-uploading correct code

Harbormaster completed remote builds in B21277: Diff 49771.Mar 28 2022, 12:24 PM

Address review

Harbormaster completed remote builds in B21282: Diff 49776.Mar 28 2022, 2:06 PM

... re-uplaoding the correct patch

Swapping the patches is forcing me to arc diff update every time and everything is a mess now :)

I hope the patches are approved soon so I can stop pushing the wrong patch up.

Harbormaster completed remote builds in B21285: Diff 49781.Mar 28 2022, 3:51 PM

Paul Larson (GeorgiaPacific) added a subscriber: Paul Larson (GeorgiaPacific).Mar 28 2022, 6:27 PM

Campbell Barton (campbellbarton) accepted this revision.Mar 30 2022, 1:21 AM

This revision is now accepted and ready to land.Mar 30 2022, 1:21 AM

Thomas Dinges (dingto) mentioned this in BF Blender (3.2).Mar 30 2022, 9:36 AM

Generally looks fine, some notes below.

source/blender/editors/object/object_modifier.c
1455–1459	Not sure about the logic of this block? If the `prop` is set, and is set to `false`, the operation should abort, not be re-started with the confirmation message?
1484	"Make the object's geometry data-block single user if needed"
1484	"Make Single User" or "Make Geometry Single User" ? 'it' does not mean anything (and certainly not the object itself, which would be the first thing I'd think about in this context)