Compositor: Support backdrop offset for the Viewer node
Needs RevisionPublic
Actions

Authored by Habib Gahbiche (zazizizou) on Mar 19 2022, 4:54 PM.

Details

Reviewers

Summary

This is only part of the experimental "Full Frame" mode (disabled
by default). See T88150.

Currently the viewer node uses buffer paddings to display image offset
in the backdrop as a temporal solution implemented for D12466: Compositor: Add support for canvas compositing.
This solution is inefficient memory and performance-wise. Another
issue is that the paddings are part the image when saved.

This patch instead sets the offset in the Viewer node image
as variables and makes the backdrop take it into account
when drawing the image or any related gizmo.

Note: This patch also fixes the panning problem from D12750

Diff Detail

Repository

rB Blender

Branch

comp_backdrop_offset (branched from master)

Build Status

Buildable 21118
Build 21118: arc lint + arc unit

Event Timeline

Habib Gahbiche (zazizizou) created this revision.Mar 19 2022, 4:54 PM

Harbormaster completed remote builds in B21118: Diff 49434.Mar 19 2022, 4:54 PM

Habib Gahbiche (zazizizou) requested review of this revision.Mar 19 2022, 4:54 PM

Habib Gahbiche (zazizizou) added a reviewer: Jeroen Bakker (jbakker).

Habib Gahbiche (zazizizou) mentioned this in D12750: Compositor: Support backdrop offset for the Viewer node.Mar 19 2022, 8:03 PM

Ethan Hall (Ethan1080) added a subscriber: Ethan Hall (Ethan1080).Mar 20 2022, 1:59 AM

Evan Wilson (EAW) added a subscriber: Evan Wilson (EAW).Mar 20 2022, 8:00 AM

Jeroen Bakker (jbakker) added 1 blocking reviewer(s): Jeroen Bakker (jbakker).Mar 22 2022, 9:34 AM

Sorry for the late reply.

After merging master in, there are some artifacts when viewing the viewer node in an image editor.

It seems that the checker board is also moved. (Could be related to other fixes)
Perhaps we should in this case crop the viewer node result so it looks the same as it used to.

Jeroen Bakker (jbakker) requested changes to this revision.May 13 2022, 1:52 PM

This revision now requires changes to proceed.May 13 2022, 1:52 PM