Add Alembic procedural to cycles xml
ClosedPublic
Actions

Authored by Charles Flèche (charlesf) on Mar 19 2022, 11:12 PM.

Details

Reviewers

Kévin Dietrich (kevindietrich)
Brecht Van Lommel (brecht)

Commits

rBe7b1be52e007: Cycles: add Alembic procedural to Cycles standalone xml

Summary

Example:

<alembic filepath="/tmp/cube.abc" scale="1.45">
  <object path="/Cube/Cube" />
</alembic>

Diff Detail

Repository: rB Blender

Event Timeline

Charles Flèche (charlesf) requested review of this revision.Mar 19 2022, 11:12 PM

Charles Flèche (charlesf) created this revision.

Harbormaster completed remote builds in B21124: Diff 49444.Mar 19 2022, 11:12 PM

Charles Flèche (charlesf) edited the summary of this revision. (Show Details)Mar 19 2022, 11:13 PM

Charles Flèche (charlesf) added a project: Cycles.

Brecht Van Lommel (brecht) requested changes to this revision.Mar 21 2022, 6:03 PM

Brecht Van Lommel (brecht) added inline comments.

intern/cycles/app/cycles_xml.cpp
207	Use `string_iequals` and don't convert unnecessarily to `ustring` here.

This revision now requires changes to proceed.Mar 21 2022, 6:03 PM

Address https://developer.blender.org/D14391#inline-121965
Set AlembicObject used shaders

Harbormaster completed remote builds in B21188: Diff 49564.Mar 22 2022, 11:43 PM

Brecht Van Lommel (brecht) accepted this revision.Mar 23 2022, 5:46 PM

This revision is now accepted and ready to land.Mar 23 2022, 5:46 PM

Closed by commit rBe7b1be52e007: Cycles: add Alembic procedural to Cycles standalone xml (authored by Charles Flèche (charlesf), committed by Brecht Van Lommel (brecht)). · Explain WhyMar 23 2022, 8:07 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rBe7b1be52e007: Cycles: add Alembic procedural to Cycles standalone xml.

Revision Contents
Changeset List

Path

Size

intern/

cycles/

app/

CMakeLists.txt

10 lines

cycles_xml.cpp

31 lines

Diff 49616

View Options

intern/cycles/app/CMakeLists.txt