Page MenuHome

Fix T96655: Bloom crashes Eevee
ClosedPublic

Authored by Hallam Roberts (MysteryPancake) on Mar 21 2022, 5:47 AM.

Details

Summary

This patch fixes T96655, bloom crashing Eevee.

The error occurs because rB472fc0c55848b2e2d428cfb4f7debb80a4e12081 added vec3 safe_color(vec3 c) to common_math_lib.glsl.

However, vec3 safe_color(vec3 c) already exists in effect_bloom_frag.glsl.
This means vec3 safe_color(vec3 c) is duplicated within common_math_lib.glsl and effect_bloom_frag.glsl.

The duplicate code in effect_bloom_frag.glsl can be removed since it's no longer needed.

(I checked the remaining methods, there shouldn't be any additional duplicate code)

Diff Detail

Repository
rB Blender
Branch
fix-bloom (branched from master)
Build Status
Buildable 21132
Build 21132: arc lint + arc unit

Event Timeline

Hallam Roberts (MysteryPancake) requested review of this revision.Mar 21 2022, 5:47 AM
Hallam Roberts (MysteryPancake) created this revision.
Hallam Roberts (MysteryPancake) edited the summary of this revision. (Show Details)
Hallam Roberts (MysteryPancake) edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Mar 21 2022, 1:15 PM
This revision was automatically updated to reflect the committed changes.