Page MenuHome
Differential D14407

Fix T96624: NLA crash when reordering tracks if no object is selected
ClosedPublic
Actions

Authored by Pratik Borhade (PratikPB2123) on Mar 22 2022, 4:25 AM.

Details

Reviewers
Bastien Montagne (mont29)
Maniphest Tasks
T96624: Regression: NLA crash when reordering tracks if no object is selected
Summary

Fix T96624

Caused by rBc0bd240ad0a1
To avoid crash, make boolean value false if active object data is NULL

Diff Detail

Repository
rB Blender

Event Timeline

Pratik Borhade (PratikPB2123) requested review of this revision.Mar 22 2022, 4:25 AM
Pratik Borhade (PratikPB2123) created this revision.
Pratik Borhade (PratikPB2123) added a subscriber: Bastien Montagne (mont29).

@Bastien Montagne (mont29) hi, would you like to review this patch? Caused by your commit- rBc0bd240ad0a1
This may not be the best solution (kind of hack)
Feel free to commit if you've alternative fix :)

Bastien Montagne (mont29) accepted this revision.Mar 22 2022, 9:08 AM

This is the proper fix indeed, those macros do not handle NULL id pointer.

source/blender/editors/animation/anim_channels_edit.c
1134

(ac->obact != NULL)

This revision is now accepted and ready to land.Mar 22 2022, 9:08 AM
Pratik Borhade (PratikPB2123) updated this revision to Diff 49520.Mar 22 2022, 10:49 AM
Pratik Borhade (PratikPB2123) marked an inline comment as done.
Bastien Montagne (mont29) accepted this revision.Mar 22 2022, 10:56 AM
Pratik Borhade (PratikPB2123) added a comment.Mar 22 2022, 11:24 AM

Thank you for reviewing :)

Can you also commit the fix?
I assume this change is safe for backporting (both 2.93, 3.1.0)

Bastien Montagne (mont29) closed this revision.Mar 22 2022, 12:06 PM

Committed as rB913b6b9ec1b1.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
animation/
2 lines

Diff 49501

View Options

source/blender/editors/animation/anim_channels_edit.c

Loading...