Page MenuHome

Curves: Improve Snake Hook brush.
ClosedPublic

Authored by Jacques Lucke (JacquesLucke) on Mar 22 2022, 10:11 AM.
Tags
None
Subscribers
None
Tokens
"Like" token, awarded by hitrpr."Love" token, awarded by kynu."Love" token, awarded by lopoIsaac."Love" token, awarded by dulrich."Love" token, awarded by HEYPictures.

Details

Summary

This implements some basic improvements to the Snake Hook brush. It now supports a spherical/3D brush and different falloff modes.

Diff Detail

Repository
rB Blender
Branch
snake-hook-brush (branched from master)
Build Status
Buildable 21162
Build 21162: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Mar 22 2022, 10:11 AM
Jacques Lucke (JacquesLucke) created this revision.
  • Merge branch 'master' into snake-hook-brush
  • initial 3d brush
  • cleanup
Jacques Lucke (JacquesLucke) retitled this revision from Curves: Improve Snake Hook brush. (WIP) to Curves: Improve Snake Hook brush. .Mar 25 2022, 10:54 AM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)

I notice that sometimes I pick up extra curve tips that weren't in the initial brush radius. Is that on purpose? I think ideally it wouldn't do that or it would be a choice. It only happens sometimes-- maybe when the tips are at the same depth as the starting point?

Other than that, the patch looks good to me.

source/blender/editors/sculpt_paint/curves_sculpt_snake_hook.cc
150–152

I wonder if this function would be simpler if you sliced the positions argument as part of calling it, and didn't pass IndexRange points

I notice that sometimes I pick up extra curve tips that weren't in the initial brush radius. Is that on purpose? I think ideally it wouldn't do that or it would be a choice. It only happens sometimes-- maybe when the tips are at the same depth as the starting point?

I'd be fine with changing that, but right now the behavior seems to match the snake hook brush for meshes. Having an option to switch between both behaviors is fine for me as well, but I think that should then be done as a separate patch.

Jacques Lucke (JacquesLucke) retitled this revision from Curves: Improve Snake Hook brush. to Curves: Improve Snake Hook brush..
  • Merge branch 'master' into snake-hook-brush
  • cleanup

Fine with me. Looks good then!

This revision is now accepted and ready to land.Mar 29 2022, 2:26 PM
This revision was automatically updated to reflect the committed changes.