Paths

Table of Contentst

Fix: Outliner Library Overrides Button Alignment
AbandonedPublic
Actions

Authored by Dominik Fill (dominikfill) on Mar 22 2022, 8:48 PM.

Details

Reviewers

Summary

Fixes the alignment of the Library Overrides Buttons in the Outiner.
Padding wasn't taken into account for multiple buttons, just for single buttons.
Also corrected y-alignment by applying appropriate padding.

master	patch

Diff Detail

Repository

rB Blender

Branch

dev-but-align (branched from master)

Build Status

Buildable 21194
Build 21194: arc lint + arc unit

Event Timeline

Dominik Fill (dominikfill) requested review of this revision.Mar 22 2022, 8:48 PM

Dominik Fill (dominikfill) created this revision.

Harbormaster completed remote builds in B21187: Diff 49560.Mar 22 2022, 8:49 PM

Dominik Fill (dominikfill) changed the visibility from "Public (No Login Required)" to "No One".Mar 22 2022, 8:49 PM

Dominik Fill (dominikfill) edited the summary of this revision. (Show Details)Mar 22 2022, 8:55 PM

Dominik Fill (dominikfill) changed the visibility from "No One" to "Public (No Login Required)".

Dominik Fill (dominikfill) added a project: User Interface.

Dominik Fill (dominikfill) updated this revision to Diff 49571.Mar 23 2022, 9:05 AM

Dominik Fill (dominikfill) edited the summary of this revision. (Show Details)

This comment was removed by Dominik Fill (dominikfill).

Harbormaster completed remote builds in B21194: Diff 49571.Mar 23 2022, 9:05 AM

cleanup

Harbormaster completed remote builds in B21195: Diff 49572.Mar 23 2022, 9:06 AM

Dominik Fill (dominikfill) edited the summary of this revision. (Show Details)Mar 23 2022, 9:14 AM

Dominik Fill (dominikfill) changed the visibility from "Public (No Login Required)" to "No One".

Dominik Fill (dominikfill) changed the visibility from "No One" to "Public (No Login Required)".Mar 23 2022, 9:17 AM

IIRC @Pablo Vazquez (pablovazquez) talked about this change in his last livestream

Add @Severin as a reviewer if patch is ready.

Use same padding for x and y

Harbormaster completed remote builds in B21196: Diff 49574.Mar 23 2022, 9:59 AM

In D14421#385976, @Pratik Borhade (PratikPB2123) wrote:

IIRC @Pablo Vazquez (pablovazquez) talked about this change in his last livestream

Add @Severin as a reviewer if patch is ready.

That's where I got the idea for the patch from!
Added @Julian Eisel (Severin) as suggested

Aww, that's very unfortunate, I've already committed some fixes including these just before you uploaded this patch 🙈 rBb40ac9684c49: Tiny visual fixes/tweaks for new library override buttons in Outliner

source/blender/editors/space_outliner/outliner_draw.cc
1813	A small problem is that this takes away from the button height, and makes it smaller than the button size we use elsewhere. Not a big problem, but may cause some small issues (e.g. with people using bigger font sizes, different fonts, etc).

In D14421#386039, @Julian Eisel (Severin) wrote:

Aww, that's very unfortunate, I've already committed some fixes including these just before you uploaded this patch 🙈 rBb40ac9684c49: Tiny visual fixes/tweaks for new library override buttons in Outliner

Ah, no worries!
What annoys me is that my initial diff was so much closer to your patch, until I started tampering with it 🙈

Dominik Fill (dominikfill) abandoned this revision.Mar 23 2022, 12:52 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_outliner/

outliner_draw.cc

8 lines

Diff 49571

View Options

source/blender/editors/space_outliner/outliner_draw.cc

Fix: Outliner Library Overrides Button AlignmentAbandonedPublicActions