Page MenuHome
Differential D14423

Cleanup: Delete unused ViewMapIO files in Freestyle
ClosedPublic
Actions

Authored by Yuki Hashimoto (hzuika) on Mar 23 2022, 5:54 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rB31bfa17a1f2b: Cleanup: delete unused ViewMapIO files in Freestyle
Summary

Cleanup: Delete unused ViewMapIO files in Freestyle

ViewMapIO.h is only included in Controller.cpp init_options().
However, g_models_path and g_flags set here are never used elsewhere.
Therefore, ViewMapIO files can be deleted without affecting anything.

Diff Detail

Repository
rB Blender
Branch
frs_cleanup_viewmapio (branched from master)
Build Status
Buildable 21190
Build 21190: arc lint + arc unit

Event Timeline

Yuki Hashimoto (hzuika) requested review of this revision.Mar 23 2022, 5:54 AM
Yuki Hashimoto (hzuika) created this revision.
Harbormaster completed remote builds in B21190: Diff 49567.Mar 23 2022, 5:54 AM
Brecht Van Lommel (brecht) accepted this revision.Mar 23 2022, 5:49 PM
This revision is now accepted and ready to land.Mar 23 2022, 5:49 PM
Closed by commit rB31bfa17a1f2b: Cleanup: delete unused ViewMapIO files in Freestyle (authored by Yuki Hashimoto (hzuika), committed by Brecht Van Lommel (brecht)). · Explain WhyMar 23 2022, 8:07 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB31bfa17a1f2b: Cleanup: delete unused ViewMapIO files in Freestyle.

Revision Contents
Changeset List

PathSize
source/
blender/
freestyle/
2 lines
intern/
application/
4 lines
view_map/

Diff 49567

View Options

source/blender/freestyle/CMakeLists.txt

Loading...
View Options

source/blender/freestyle/intern/application/Controller.cpp

Loading...
View Options

source/blender/freestyle/intern/view_map/ViewMapIO.h

Loading...
View Options

source/blender/freestyle/intern/view_map/ViewMapIO.cpp

Loading...