Paths

Table of Contentst

Differential D14431

Cleanup: Adjust naming in new curves code
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Mar 23 2022, 6:41 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)

Commits

rBe253f9f66d6f: Cleanup: Adjust naming in new curves code

Summary

Rename "size" variables and functions to use "num" instead,
based on T85728 (though this doesn't apply to simple C++
containers, it applies here). Rename "range" to "points" in
some functions, so be more specific.

Diff Detail

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Mar 23 2022, 6:41 PM

Hans Goudey (HooglyBoogly) created this revision.

Jacques Lucke (JacquesLucke) accepted this revision.Mar 23 2022, 8:27 PM

This revision is now accepted and ready to land.Mar 23 2022, 8:27 PM

Closed by commit rBe253f9f66d6f: Cleanup: Adjust naming in new curves code (authored by Hans Goudey (HooglyBoogly)). · Explain WhyMar 24 2022, 5:06 AM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rBe253f9f66d6f: Cleanup: Adjust naming in new curves code.

T85728 notes that num should be used as a suffix.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

BKE_curves.hh

38 lines

intern/

6 lines

4 lines

40 lines

84 lines

curves_geometry_test.cc

2 lines

geometry_component_curves.cc

4 lines

draw/

intern/

draw_cache_impl_curves.cc

6 lines

editors/

curves/

intern/

curves_add.cc

4 lines

sculpt_paint/

curves_sculpt_add.cc

14 lines

curves_sculpt_comb.cc

2 lines

curves_sculpt_delete.cc

2 lines

curves_sculpt_ops.cc

12 lines

curves_sculpt_snake_hook.cc

2 lines

geometry/

intern/

realize_instances.cc

8 lines

nodes/

geometry/

nodes/

node_geo_curve_endpoint_selection.cc

8 lines

node_geo_curve_fill.cc

6 lines

node_geo_curve_handle_type_selection.cc

2 lines

node_geo_duplicate_elements.cc

22 lines

node_geo_input_spline_length.cc

6 lines

Diff 49606

View Options

source/blender/blenkernel/BKE_curves.hh

View Options

source/blender/blenkernel/intern/curve_catmull_rom.cc

View Options

source/blender/blenkernel/intern/curve_eval.cc

View Options

source/blender/blenkernel/intern/curve_nurbs.cc

View Options

source/blender/blenkernel/intern/curves_geometry.cc

View Options

source/blender/blenkernel/intern/curves_geometry_test.cc

View Options

source/blender/blenkernel/intern/geometry_component_curves.cc

View Options

source/blender/draw/intern/draw_cache_impl_curves.cc

View Options

source/blender/editors/curves/intern/curves_add.cc

View Options

source/blender/editors/sculpt_paint/curves_sculpt_add.cc

View Options

source/blender/editors/sculpt_paint/curves_sculpt_comb.cc

View Options

source/blender/editors/sculpt_paint/curves_sculpt_delete.cc

View Options

source/blender/editors/sculpt_paint/curves_sculpt_ops.cc

View Options

source/blender/editors/sculpt_paint/curves_sculpt_snake_hook.cc

View Options

source/blender/geometry/intern/realize_instances.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_endpoint_selection.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_fill.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_handle_type_selection.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_duplicate_elements.cc

View Options

source/blender/nodes/geometry/nodes/node_geo_input_spline_length.cc

Cleanup: Adjust naming in new curves codeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49606

source/blender/blenkernel/BKE_curves.hh

source/blender/blenkernel/intern/curve_catmull_rom.cc

source/blender/blenkernel/intern/curve_eval.cc

source/blender/blenkernel/intern/curve_nurbs.cc

source/blender/blenkernel/intern/curves_geometry.cc

source/blender/blenkernel/intern/curves_geometry_test.cc

source/blender/blenkernel/intern/geometry_component_curves.cc

source/blender/draw/intern/draw_cache_impl_curves.cc

source/blender/editors/curves/intern/curves_add.cc

source/blender/editors/sculpt_paint/curves_sculpt_add.cc

source/blender/editors/sculpt_paint/curves_sculpt_comb.cc

source/blender/editors/sculpt_paint/curves_sculpt_delete.cc

source/blender/editors/sculpt_paint/curves_sculpt_ops.cc

source/blender/editors/sculpt_paint/curves_sculpt_snake_hook.cc

source/blender/geometry/intern/realize_instances.cc

source/blender/nodes/geometry/nodes/node_geo_curve_endpoint_selection.cc

source/blender/nodes/geometry/nodes/node_geo_curve_fill.cc

source/blender/nodes/geometry/nodes/node_geo_curve_handle_type_selection.cc

source/blender/nodes/geometry/nodes/node_geo_duplicate_elements.cc

source/blender/nodes/geometry/nodes/node_geo_input_spline_length.cc

Cleanup: Adjust naming in new curves code
ClosedPublic
Actions

Revision Contents
Changeset List