Cleanup: Delete unused files about path in Freestyle.
AbandonedPublic
Actions

Authored by Yuki Hashimoto (hzuika) on Mar 23 2022, 11:28 PM.

Details

Reviewers

Summary

Cleanup: Delete unused files about path in Freestyle.

The directory paths (_PatternsPath, _BrushesPath, _EnvMapDir, _MapsDir) in AppConfig.h do not exist in current Blender.
(These directories have been removed since 2.70.)
Therefore, these have been deleted.

[version number]/scripts/freestyle/data/textures/variation_patterns/
[version number]/scripts/freestyle/data/textures/brushes/
[version number]/scripts/freestyle/data/env_map/
[version number]/scripts/freestyle/data/maps/

Several unused functions and files related to this have also been deleted.

Diff Detail

Repository

rB Blender

Branch

frs_cleanup_path (branched from master)

Build Status

Buildable 21218
Build 21218: arc lint + arc unit

Event Timeline

Yuki Hashimoto (hzuika) requested review of this revision.Mar 23 2022, 11:28 PM

Yuki Hashimoto (hzuika) created this revision.

Harbormaster completed remote builds in B21218: Diff 49627.Mar 23 2022, 11:28 PM

Yuki Hashimoto (hzuika) edited the summary of this revision. (Show Details)Mar 23 2022, 11:40 PM

Will those scripts be usable if it's included? like brush/patterns presets and stuff? I think it might just be the installation didn't include them?

In D14434#386336, @YimingWu (NicksBest) wrote:

Will those scripts be usable if it's included? like brush/patterns presets and stuff? I think it might just be the installation didn't include them?

I checked the contents of the blender 2.69 directory.
maps was not found. The rest are as follows.

variation_patterns (_PatternsPath)
Dash patterns and gradation patterns.

brushes (_BrushesPath)

env_map (_EnvMapDir)

These appear to be presets. It may be useful to have it, but it does not seem to be required.
I also believe that Freestyle source code needs to be edited in order to load them. It cannot be loaded in its current code.
I do not know why this directory was lost, but since LineStyle Geometry and Texture are available, I think there is no need to use them.

Then it's probably good to remove... These should be available on freestyle's website anyway if we need to use them for some purposes.

@Yuki Hashimoto (hzuika), what's the reason behind these Freestyle cleanups?

This code is mostly unmaintained without any active development. Cleanups can help with development, but if that's not happening it mainly risks breaking things, so it's not obvious why this is worth spending time on.

In D14434#386649, @Brecht Van Lommel (brecht) wrote:

@Yuki Hashimoto (hzuika), what's the reason behind these Freestyle cleanups?

This code is mostly unmaintained without any active development. Cleanups can help with development, but if that's not happening it mainly risks breaking things, so it's not obvious why this is worth spending time on.

@Brecht Van Lommel (brecht), thank you for your comment.
There's no particular reason for the cleanup.

One of the reasons for the lack of active development may be the difficulty in reading the source code.
But as you said, it does not seem worth the cost.

I keep this patch closed until active development of Freestyle.