Page MenuHome
Differential D14443

Cleanup: Fix various typos (code and comments)
ClosedPublic
Actions

Authored by luzpaz (luzpaz) on Mar 24 2022, 10:08 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Hans Goudey (HooglyBoogly)
Commits
rB5f1adfc508cf: Cleanup: fix various typos
Summary

There is a source typo (that may be a bug fix) within this patch, please review closely.

Diff Detail

Repository
rB Blender

Event Timeline

luzpaz (luzpaz) requested review of this revision.Mar 24 2022, 10:08 PM
luzpaz (luzpaz) created this revision.
luzpaz (luzpaz) added inline comments.
source/blender/nodes/geometry/nodes/node_geo_convex_hull.cc
248

Source typo?

Hans Goudey (HooglyBoogly) added a subscriber: Hans Goudey (HooglyBoogly).Mar 24 2022, 11:00 PM
Hans Goudey (HooglyBoogly) added inline comments.
source/blender/nodes/geometry/nodes/node_geo_convex_hull.cc
248

I don't see the context, but this is probably in the section of disabled code in this file, so it doesn't get compiled. Fine to change it though.

luzpaz (luzpaz) added inline comments.Mar 24 2022, 11:38 PM
source/blender/nodes/geometry/nodes/node_geo_convex_hull.cc
248

context: https://github.com/blender/blender/blob/master/source/blender/nodes/geometry/nodes/node_geo_convex_hull.cc#L248

luzpaz (luzpaz) added a comment.Mar 27 2022, 7:46 PM

@Hans Goudey (HooglyBoogly) I'm not sure the code is in a disabled section. Can you confirm via the context above?

Hans Goudey (HooglyBoogly) added a comment.Mar 28 2022, 2:30 AM

Yes, it is, see # if 0

luzpaz (luzpaz) added a comment.Mar 29 2022, 2:12 PM
In D14443#387367, @Hans Goudey (HooglyBoogly) wrote:

Yes, it is, see # if 0

Indeed. But you still approve of the merge nonetheless?

Hans Goudey (HooglyBoogly) accepted this revision.Mar 29 2022, 2:21 PM
This revision is now accepted and ready to land.Mar 29 2022, 2:21 PM
Closed by commit rB5f1adfc508cf: Cleanup: fix various typos (authored by Brecht Van Lommel (brecht)). · Explain WhyApr 5 2022, 10:26 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB5f1adfc508cf: Cleanup: fix various typos.

Revision Contents
Changeset List

PathSize
release/
scripts/
modules/
bpy/
utils/
2 lines
source/
blender/
blenlib/
intern/
2 lines
freestyle/
intern/
stroke/
2 lines
view_map/
4 lines
nodes/
geometry/
nodes/
2 lines
creator/
2 lines

Diff 50133

View Options

release/scripts/modules/bpy/utils/__init__.py

Loading...
View Options

source/blender/blenlib/intern/array_store.c

Loading...
View Options

source/blender/freestyle/intern/stroke/StrokeTesselator.h

Loading...
View Options

source/blender/freestyle/intern/view_map/ViewMapTesselator.h

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_convex_hull.cc

Loading...
View Options

source/creator/creator_args.c

Loading...