Page MenuHome
Differential D14450

Fix: improve quick fluid effects
Needs ReviewPublic
Actions

Authored by Ethan Hall (Ethan1080) on Mar 25 2022, 10:12 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This patch makes a few tweaks to quick smoke and quick liquid.

  1. Quick liquid now enables "use mesh" in the liquid domain options.
    • This is a bug-fix.
  2. Quick smoke/liquid now disable the inflow object in render according to the operator setting.
    • This is a bug-fix.
  3. Quick liquid EEVEE and viewport material settings are tweaked.
    • 'Screen Space Refraction' is now enabled for the material. (Users still must enable the SSR+Refraction in render properties if they want the effect.)
    • The viewport material color, roughness, and alpha are set to better represent water.
  4. Quick liquid now uses the Principled BSDF for EEVEE.
    • Note that the volume absorption will not work with the fluid mesh in EEVEE, so it is omitted.
    • The settings for the shader can be seen below.

Here are the changes summed up in one image:

Diff Detail

Repository
rB Blender
Branch
quick_effect_fix (branched from master)
Build Status
Buildable 21244
Build 21244: arc lint + arc unit

Event Timeline

Ethan Hall (Ethan1080) requested review of this revision.Mar 25 2022, 10:12 AM
Ethan Hall (Ethan1080) created this revision.
Harbormaster completed remote builds in B21244: Diff 49690.Mar 25 2022, 10:12 AM
Ethan Hall (Ethan1080) added a subscriber: Thomas Dinges (dingto).Mar 25 2022, 10:14 AM
Thomas Dinges (dingto) added a comment.Mar 25 2022, 11:04 AM

Thanks, changes look good.

Can we change the fluid material color for EEVEE though? Grey on grey is barely visible in the viewport render. Maybe make it a bit blueish?

In general I would always make sure, that these quick effects work fine with the default cube scene.

Ethan Hall (Ethan1080) added a comment.EditedMar 25 2022, 11:23 AM

Sure, we can tint it a little. I just don't want to make it too unrealistic.

How do you feel about this?

I can create a Principle BSDF setup for EEVEE.

Thomas Dinges (dingto) added subscribers: Jacques Lucke (JacquesLucke), Dalai Felinto (dfelinto).Mar 25 2022, 11:37 AM

That should be fine.

Adding @Dalai Felinto (dfelinto) @Jacques Lucke (JacquesLucke) as Nodes & Physics module owners.

Jacques Lucke (JacquesLucke) added a comment.Mar 25 2022, 11:58 AM

While this seems generally fine (haven't looked at the details of the change), I'd want more artist feedback in this patch before accepting it. Maybe the changed defaults work better for you, but not generally, hard to say without more feedback.

Ethan Hall (Ethan1080) updated this revision to Diff 49697.Mar 25 2022, 12:14 PM
  • Added Principled BSDF and material output for EEVEE.
Harbormaster completed remote builds in B21247: Diff 49697.Mar 25 2022, 12:14 PM
Ethan Hall (Ethan1080) edited the summary of this revision. (Show Details)Mar 25 2022, 12:44 PM
Ethan Hall (Ethan1080) retitled this revision from Fix: Make quick effects more useful to Fix: improve quick fluid effects.Mar 25 2022, 2:47 PM
Ethan Hall (Ethan1080) edited the summary of this revision. (Show Details)
Ethan Hall (Ethan1080) added a project: Nodes & Physics.
Thomas Dinges (dingto) added a comment.Mar 25 2022, 4:56 PM

@Jacques Lucke (JacquesLucke) I leave the final decision to you then. :) But the quick liquid is broken in master, without the Use_Mesh option enabled you can only see the sim in wireframe mode.

Jacques Lucke (JacquesLucke) added a comment.Mar 25 2022, 5:41 PM

Well then it would be nice to separate fixes from other changes of the behavior.

Ethan Hall (Ethan1080) added a comment.EditedMar 25 2022, 5:55 PM
In D14450#387017, @Jacques Lucke (JacquesLucke) wrote:

Well then it would be nice to separate fixes from other changes of the behavior.

Technically, all four can be considered bug-fixes.
1 and 2 are general fixes that apply regardless of render engine.
3 and 4 fix the fact that quick liquid's material settings only work well for Cycles. Quick liquid currently neglects EEVEE and Workbench.

In another sense, none of these are bug-fixes. Since the quick effects just configure some default options, all the changes I made could just be seen as a different preference for how the defaults should be configured.

Thomas Dinges (dingto) mentioned this in T101188: Regression: Fluid Physics not working.Sep 19 2022, 2:45 PM

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_operators/
10 lines

Diff 49690

View Options

release/scripts/startup/bl_operators/object_quick_effects.py

Loading...