Page MenuHome
Differential D14461

Curves: Port parameter node to the new data-block
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Mar 25 2022, 9:21 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Commits
rBf4f89a76a8f4: Curves: Port parameter node to the new data-block
Summary

Using the evaluated lengths cache from D14382, re-implement the
curve parameter node with the new data structure. Conceptually
it works the same way, but the code is restructured and cleaned up
a bit as well. This also adds support for Catmull Rom curves.

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Mar 25 2022, 9:21 PM
Hans Goudey (HooglyBoogly) created this revision.
Hans Goudey (HooglyBoogly) added a parent revision: D14382: Curves: Add length cache, length paramerterize utility.
Hans Goudey (HooglyBoogly) retitled this revision from Curves: Port curve parameter node to the new data-block to Curves: Port parameter node to the new data-block.
Hans Goudey (HooglyBoogly) added a child revision: D14462: Curves: Port curves total length node to the new data-block.Mar 25 2022, 9:42 PM
Hans Goudey (HooglyBoogly) added a child revision: D14463: Curves: Port length node to the new data-block.Mar 25 2022, 9:58 PM
Hans Goudey (HooglyBoogly) mentioned this in T95443: Refactor curve nodes to use new data structure.Mar 25 2022, 10:32 PM
Jacques Lucke (JacquesLucke) accepted this revision.Mar 27 2022, 1:05 PM
Jacques Lucke (JacquesLucke) added inline comments.
source/blender/blenkernel/BKE_curves.hh
277

evalauted

source/blender/blenlib/intern/length_parameterize.cc
3 ↗(On Diff #49726)

Shouldn't be necessary in a .cc file.

source/blender/nodes/geometry/nodes/node_geo_curve_spline_parameter.cc
55

Mention that this is done because there is no clear mapping between control points and points on the curve.

This revision is now accepted and ready to land.Mar 27 2022, 1:05 PM
Jacques Lucke (JacquesLucke) added inline comments.Mar 27 2022, 1:05 PM
source/blender/nodes/geometry/nodes/node_geo_curve_spline_parameter.cc
3

Is this even used?

Hans Goudey (HooglyBoogly) marked 4 inline comments as done.Mar 30 2022, 3:10 AM
Closed by commit rBf4f89a76a8f4: Curves: Port parameter node to the new data-block (authored by Hans Goudey (HooglyBoogly)). · Explain WhyMar 30 2022, 3:12 AM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rBf4f89a76a8f4: Curves: Port parameter node to the new data-block.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
7 lines
intern/
12 lines
nodes/
geometry/
nodes/
229 lines

Diff 49883

View Options

source/blender/blenkernel/BKE_curves.hh

Loading...
View Options

source/blender/blenkernel/intern/curves_geometry.cc

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_curve_spline_parameter.cc

Loading...