The tool-tips and the text in front of the sliders differ in the alembic exporter options, this has been fixed.
A grammar fix in the description of "Geometry Samples" has been made.
Before:
After:
Details
Details
- Reviewers
Hans Goudey (HooglyBoogly)
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
Hi, thanks for the patch.
Please change "Edit policy" to All Users
I don't have commit rights so need to poke someone else for the review
Comment Actions
Do I need to add a reviewer as well?
I'm not familiar with the org structure so I need some help getting acquainted with the process.
Thanks for helping out!
Comment Actions
Thanks for the patch. The grammar fix from "are" to "is" is good, the rest of the changes shouldn't be included, since they revert purposeful changes.
| source/blender/editors/io/io_alembic.c | ||
|---|---|---|
| 179–187 | The way this is done might not be obvious, but the order and lack of repetition of words is on purpose and it's commonly done this way in Blender's UI. Putting the most important word first and omitting it in subsequent "aligned" buttons makes scanning the text easier, and makes it easier to find common elements. You'll see the "Frame Start" -> "End" or "Value Min" -> "Max" in a lot of places. | |
Comment Actions
@Hans Goudey (HooglyBoogly) The UI naming conventions make sense now. Thanks for the review. Could you please take a look at T91541: Freestyle Modifer - curvature 3d versus 3d curvature which has a similar issue? I'll stop working on that as well.
Comment Actions
Could you please take a look at T91541 which has a similar issue? I'll stop working on that as well.
In that case, I think it's fine to change one of them so they're consistent. I don't have a strong opinion which one.
Comment Actions
I'm actually not sure this is a grammar error. I think data could be plural here and it would be correct. At least I'm not convinced enough to commit this patch at the moment.