Page MenuHome
Differential D14472

Fix T96812: edit mode snap still has issues
AbandonedPublic
Actions

Authored by Ethan Hall (Ethan1080) on Mar 28 2022, 3:09 AM.

Details

Reviewers
Germano Cavalcante (mano-wii)
Summary

Regression introduced in 4b35d6950d4f

This fixes snapping when using proportional editing.
This also fixes the inverted behavior of 'Project onto Self
when in multi-object edit mode.

SNAP_NOT_ACTIVEshould ensure that base is not in edit mode.

Diff Detail

Repository
rB Blender
Branch
fix_t96812 (branched from master)
Build Status
Buildable 21266
Build 21266: arc lint + arc unit

Event Timeline

Ethan Hall (Ethan1080) requested review of this revision.Mar 28 2022, 3:09 AM
Ethan Hall (Ethan1080) created this revision.
Harbormaster completed remote builds in B21266: Diff 49756.Mar 28 2022, 3:09 AM
Ethan Hall (Ethan1080) mentioned this in T96812: Regression: Snapping is broken with proportional editing.Mar 28 2022, 3:10 AM
Ethan Hall (Ethan1080) mentioned this in rB4b35d6950d4f: Fix T96711: snap in edit mode for selected objects does not work.
Germano Cavalcante (mano-wii) abandoned this revision.Mar 28 2022, 4:32 PM

Thanks for the patch @Ethan Hall (Ethan1080)
I submitted a slightly different solution: rB2e99295d5e17: Fix T96812: Regression: Snapping is broken with proportional editing

Technically, the regression and the other issue should be reported and fixed separately.
(But since the fix is kind of related, I went after fixing both together).

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
transform/
3 lines

Diff 49756

View Options

source/blender/editors/transform/transform_snap_object.c

Loading...