Page MenuHome

Fix T80586: Allow Case-Only File Renaming
Needs RevisionPublic

Authored by Harley Acheson (harley) on Mar 30 2022, 10:17 PM.

Details

Summary

Allow file renaming when changing nothing but case.


As T80586: File Browser unable to rename with Upper/Lower case shows you cannot Rename in File Browser and change a file name from "test" to "Test", where the letters remain the same but only the case changes.

File Browser's renamebutton_cb that has an unnecessary check to ensure that the new name does not exist, even though the renaming function it calls, BLI_rename, handles this situation correctly.

Diff Detail

Repository
rB Blender

Event Timeline

Harley Acheson (harley) requested review of this revision.Mar 30 2022, 10:17 PM
Harley Acheson (harley) created this revision.
Harley Acheson (harley) edited the summary of this revision. (Show Details)
Harley Acheson (harley) edited the summary of this revision. (Show Details)

Updated to the current state of master.

Brecht Van Lommel (brecht) requested changes to this revision.Aug 17 2022, 8:40 PM

File Browser's renamebutton_cb that has an unnecessary check to ensure that the new name does not exist, even though the renaming function it calls, BLI_rename, handles this situation correctly.

From what I can tell BLI_rename will delete any existing file with the new name, which does not seem like the correct behavior. Also check the Linux/macOS implementation which does not look at case.

This revision now requires changes to proceed.Aug 17 2022, 8:40 PM