Page MenuHome
Differential D1452

Support building OpenSubdiv libraries under Debian (Ubuntu) with our build_deps.sh script.
ClosedPublic
Actions

Authored by Thomas Beck (plasmasolutions) on Aug 6 2015, 3:03 PM.

Details

Reviewers
Bastien Montagne (mont29)
Sergey Sharybin (sergey)
Commits
rBSdbdc55ab6ada: Support building OpenSubdiv libraries under Debian (Ubuntu) with our…
rBdbdc55ab6ada: Support building OpenSubdiv libraries under Debian (Ubuntu) with our…
Summary

Use --skip-osd to skip building opensubdiv libs,
use --force-osd to force a rebuild of the libs.

I added all needed user information (where to find the include dir, which -D options to set) to the print_info method that is called at the end too, so it should be pretty intuitive to use.

Diff Detail

Repository
rB Blender

Event Timeline

Thomas Beck (plasmasolutions) updated this revision to Diff 4822.Aug 6 2015, 3:03 PM
Thomas Beck (plasmasolutions) retitled this revision from to Support building OpenSubdiv libraries under Debian (Ubuntu) with our build_deps.sh script..
Thomas Beck (plasmasolutions) added a reviewer: Sergey Sharybin (sergey).
Thomas Beck (plasmasolutions) updated this object.
Thomas Beck (plasmasolutions) updated this revision to Diff 4823.Aug 6 2015, 3:14 PM
  • Missed this wrong force option in the last commit.
Thomas Beck (plasmasolutions) updated this revision to Diff 4824.Aug 6 2015, 3:18 PM
  • Accidentially changed osl option... reverted it to previous state
Sergey Sharybin (sergey) edited edge metadata.Aug 6 2015, 3:54 PM
Sergey Sharybin (sergey) added a subscriber: Bastien Montagne (mont29).

Some minor feedback, but @Bastien Montagne (mont29) is the one who is the most familiar with the script.

To me it seems rather fine.

build_files/build_environment/install_deps.sh
537

v3_0_2 is to be replaced with OSD_VERSION?

Thomas Beck (plasmasolutions) added a comment.Aug 6 2015, 4:04 PM

Hi Sergey,

great,... will wait for mont then and fix the minor flaw in the meantime :)

Greetings and wish you an awesome trip to LA!

build_files/build_environment/install_deps.sh
537

100% ack .. will change that!

Thomas Beck (plasmasolutions) updated this revision to Diff 4825.Aug 6 2015, 4:20 PM
Thomas Beck (plasmasolutions) edited edge metadata.

Changed the fixed version string (from the archive) to a variable one.

Thomas Beck (plasmasolutions) marked an inline comment as done.Aug 6 2015, 4:22 PM

Solved the fixed version string...weird that I can't commit a "done" item without posting a comment...

Bastien Montagne (mont29) added a comment.Aug 6 2015, 4:51 PM

Ah, wanted to add this, nice to have a start point, thanks a bunch.

Will check, and add other distro code as well (should not be really hard).

Bastien Montagne (mont29) added a reviewer: Bastien Montagne (mont29).Aug 6 2015, 4:51 PM
Bastien Montagne (mont29) accepted this revision.Aug 7 2015, 9:55 PM
Bastien Montagne (mont29) edited edge metadata.

Aside from minor note below, patch lgtm.

build_files/build_environment/install_deps.sh
3156–3158

Replace those three by single:

_2="-D OPENSUBDIV_ROOT_DIR=$INST/osd"

Also, below we lack the scons options, something like:

if [ "$OSD_SKIP" = false ]; then
  PRINT "WITH_BF_OPENSUBDIV = True"
  if [ -d $INST/osd ]; then
    PRINT "BF_OPENSUBDIV = '$INST/osd'"
  fi
fi
This revision is now accepted and ready to land.Aug 7 2015, 9:55 PM
Closed by commit rBdbdc55ab6ada: Support building OpenSubdiv libraries under Debian (Ubuntu) with our… (authored by Thomas Beck (plasmasolutions)). · Explain WhyAug 8 2015, 2:13 PM
This revision was automatically updated to reflect the committed changes.
Leon Cheung (leon_cheung) awarded a token.Aug 8 2015, 3:00 PM

Revision Contents
Changeset List

PathSize
build_files/
build_environment/
157 lines

Diff 4829

View Options

build_files/build_environment/install_deps.sh

Loading...