Page MenuHome
Differential D14549

Refactor: Deduplicate and simplify BVH Utils code
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Apr 4 2022, 10:44 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rB228f7f1c8508: Refactor: Deduplicate and simplify BVH Utils code
Summary
  • Merge all bvhtree_from_mesh_*.*_setup_data in a single utility
  • Create bvhtree_from_editmesh_setup_data
  • Setup data only once in BKE_bvhtree_from_mesh_get and BKE_bvhtree_from_editmesh_get

Functional changes in BKE_bvhtree_from_mesh_get and BKE_bvhtree_from_editmesh_get:

  • If a null tree is cached, don't set the data to zero. This tree is not an error and the others members can still be used.
  • If a null tree is returned, don't set the data to zero. Matches the previous change.
  • If a null tree is returned, do not call free_bvhtree_from_mesh or free_bvhtree_from_editmesh. They don't do anything in this case.

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 21459
Build 21459: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) requested review of this revision.Apr 4 2022, 10:44 PM
Germano Cavalcante (mano-wii) created this revision.
Harbormaster completed remote builds in B21459: Diff 50092.Apr 4 2022, 10:44 PM
Germano Cavalcante (mano-wii) mentioned this in D14479: Cleanup/Refactor: remove cache parameters from `bvhtree_from_` functions.Apr 4 2022, 10:45 PM
Germano Cavalcante (mano-wii) edited the summary of this revision. (Show Details)
Germano Cavalcante (mano-wii) updated this revision to Diff 50093.Apr 4 2022, 11:46 PM
  • missed data->cached setup member
Harbormaster completed remote builds in B21460: Diff 50093.Apr 4 2022, 11:46 PM
Germano Cavalcante (mano-wii) updated this revision to Diff 50094.Apr 4 2022, 11:49 PM
  • Read the in_cache variable to set the data->cache when available
Harbormaster completed remote builds in B21461: Diff 50094.Apr 4 2022, 11:49 PM
Germano Cavalcante (mano-wii) planned changes to this revision.Apr 4 2022, 11:58 PM

data->cached still unset in some places

Germano Cavalcante (mano-wii) updated this revision to Diff 50095.Apr 5 2022, 12:06 AM
  • missed data->cached
Harbormaster completed remote builds in B21462: Diff 50095.Apr 5 2022, 12:06 AM
Brecht Van Lommel (brecht) accepted this revision.Apr 5 2022, 10:17 PM

It looks correct to me. The fact that there's two ways to fill in data is still very confusing to me, but seems no worse than before.

This revision is now accepted and ready to land.Apr 5 2022, 10:17 PM
Closed by commit rB228f7f1c8508: Refactor: Deduplicate and simplify BVH Utils code (authored by Germano Cavalcante (mano-wii)). · Explain WhyApr 5 2022, 11:15 PM
This revision was automatically updated to reflect the committed changes.
Germano Cavalcante (mano-wii) added a commit: rB228f7f1c8508: Refactor: Deduplicate and simplify BVH Utils code.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
631 lines

Diff 50092

View Options

source/blender/blenkernel/intern/bvhutils.cc

Loading...