Added material object to uniforms from gpu.export_shader
ClosedPublic
Actions

Authored by Sebastian Ullrich (souljedi) on Aug 10 2015, 3:11 PM.

Details

Reviewers

Commits

rB7e6fa6ea8c33: Python API: add material to uniforms from gpu.export_shader.
rBS6bd248cd6540: Python API: add material to uniforms from gpu.export_shader.
rB6bd248cd6540: Python API: add material to uniforms from gpu.export_shader.

Summary

Light related uniforms (GPU_DYNAMIC_LAMP... types etc) already have a reference to the according lamp object. With this patch I added the same for material related uniforms (GPU_DYNAMIC_MAT_...). This is needed for exporters that are accessing the uniforms via the python interface. I already tested it with an exented version of the X3D exporter, which i will submit via patches as well.

This is my first patch here, so excuse me if i file it in the wrong sections etc.

Diff Detail

Repository: rB Blender

Event Timeline

Sebastian Ullrich (souljedi) updated this revision to Diff 4841.Aug 10 2015, 3:11 PM

Sebastian Ullrich (souljedi) retitled this revision from to Added material object to uniforms from gpu.export_shader.

Sebastian Ullrich (souljedi) updated this object.

Sebastian Ullrich (souljedi) added a reviewer: Campbell Barton (campbellbarton).

Sebastian Ullrich (souljedi) set the repository for this revision to rB Blender.

Sebastian Ullrich (souljedi) added projects: BF Blender, GPU / Viewport, Add-ons (BF-Blender).

@Antonis Ryakiotakis (psy-fi) is this something you are familiar with? The patch seems harmless nevertheless (and it's required for an upcoming upgraded x3d exporter).

Michael Otto (mayqel) added a subscriber: Michael Otto (mayqel).Aug 28 2015, 11:46 AM

any chances this could still make it into the upcoming 2.76 release?

Not so close to release, no.

Campbell Barton (campbellbarton) edited reviewers, added: Antonis Ryakiotakis (psy-fi); removed: Campbell Barton (campbellbarton).Sep 17 2015, 3:30 PM

So, the release is out for a while now. Any chances of getting this in now?

Hi, I'm still waiting for this to get reviewed. Since i submitted it, there were already several new releases...

Let me know if there is anything I can do to get this finally merged?

Julian Eisel (Severin) edited reviewers, added: Brecht Van Lommel (brecht); removed: Antonis Ryakiotakis (psy-fi).May 18 2016, 12:08 PM

Closed by commit rB6bd248cd6540: Python API: add material to uniforms from gpu.export_shader. (authored by Sebastian Ullrich (souljedi), committed by Brecht Van Lommel (brecht)). · Explain WhyMay 21 2016, 5:05 PM

This revision was automatically updated to reflect the committed changes.

Committed now, thanks for the patch!