Differential D1460

lattice boundingboxes (and armature boundingbox cleanup)
AbandonedPublic
Actions

Authored by Bastien Montagne (mont29) on Aug 12 2015, 6:30 PM.

Tags

None

Subscribers

Campbell Barton (campbellbarton)

Ray Mairlot (madog)

Details

Reviewers

Philipp Oeser (lichtwerk)

Summary

this will:

draw lattice boundingboxes in 3dView [if "show_bounds" is used -- an option previously pretty useless for lattices]
give proper values for lattice objects ".bound_box" in bpy
give proper values for armature objects ".bound_box" in bpy
lets users use "Dimensions" [in 3dView Transform panel] on lattices and armatures
remove redundant calculations in "boundbox_armature()"
(armatures boundingboxes were already drawn in 3dView [if "show_bounds" is used])

based on report T45735: Lattice's bounding_box doesn't update and a comment in code by @Campbell Barton (campbellbarton) "* later we may want to add dimensions for lattice, armature etc too */

Diff Detail

Event Timeline

Philipp Oeser (lichtwerk) updated this revision to Diff 4846.Aug 12 2015, 6:30 PM

Philipp Oeser (lichtwerk) retitled this revision from to lattice boundingboxes (and armature boundingbox cleanup).

Philipp Oeser (lichtwerk) updated this object.

Philipp Oeser (lichtwerk) added a reviewer: Bastien Montagne (mont29).

Philipp Oeser (lichtwerk) added a subscriber: Campbell Barton (campbellbarton).

Philipp Oeser (lichtwerk) mentioned this in T45735: Lattice's bounding_box doesn't update.Aug 12 2015, 6:34 PM

Ray Mairlot (madog) added a subscriber: Ray Mairlot (madog).Aug 12 2015, 6:37 PM

Aside from picky details noted below, LGTM. :)

source/blender/blenkernel/intern/armature.c
2191	You can change that one to malloc too…
source/blender/blenkernel/intern/lattice.c
1149	No need to calloc here, malloc is enough ;)

This revision is now accepted and ready to land.Aug 12 2015, 8:19 PM

review by @Bastien Montagne (mont29):

replace MEM_callocN with MEM_mallocN for both lattice/armature bb allocation

@Philipp Oeser (lichtwerk) if you have commit rights, feel free to go on and commit (otherwise, please tell, and I’ll commit it on your behalf).

@Bastien Montagne (mont29): please go ahead (I dont have commit rights), and thanx for review :)

Bastien Montagne (mont29) commandeered this revision.Aug 13 2015, 7:14 PM

Bastien Montagne (mont29) edited reviewers, added: Philipp Oeser (lichtwerk); removed: Bastien Montagne (mont29).

This revision now requires review to proceed.Aug 13 2015, 7:14 PM

sigh at tracker auto-magic…

Committed as rB3fa0a1a5bc0ff2, thanks. :)

little followup on this: D1462: lattice boundingbox: base calculation on DispList

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

1 line

intern/

18 lines

25 lines

7 lines

editors/

space_view3d/

3 lines

view3d_buttons.c

5 lines

Diff 4853

source/blender/blenkernel/BKE_lattice.h

Loading...

source/blender/blenkernel/intern/armature.c

Loading...

source/blender/blenkernel/intern/lattice.c

Loading...

source/blender/blenkernel/intern/object.c

Loading...

source/blender/editors/space_view3d/drawobject.c

Loading...

source/blender/editors/space_view3d/view3d_buttons.c

Loading...