FBX Importer: add option to remove duplicate data
Needs ReviewPublic
Actions

Authored by Ethan Hall (Ethan1080) on Apr 11 2022, 1:25 PM.

Details

Reviewers

Summary

This patch adds an option to the FBX import menu that allows the user
to avoid importing duplicate UV map and color layers.

I used this Mixamo model for testing since it contains more than 8 UV maps and only two of the UV maps are unique.

kachujin_g_rosales-Idle.fbx16 MBDownload

Diff Detail

Repository

rBA Blender Add-ons

Branch

fbx_dupe_layers

Build Status

Buildable 21585
Build 21585: arc lint + arc unit

Event Timeline

Ethan Hall (Ethan1080) requested review of this revision.Apr 11 2022, 1:25 PM

Ethan Hall (Ethan1080) created this revision.

Harbormaster completed remote builds in B21578: Diff 50323.Apr 11 2022, 1:26 PM

Ethan Hall (Ethan1080) edited the summary of this revision. (Show Details)Apr 11 2022, 1:33 PM

Thanks for the patch, but it mixes new features and tweaks to (unrelated) existing UI messages, this is not acceptable. Please separate such unrelated changes into different patches.

Further more, am not convinced we should add that extra code complexity here to fix (somewhat) invalid input data... @Campbell Barton (campbellbarton) , @Dalai Felinto (dfelinto), what do you think? Should our importers try to 'fix' things like duplicated data?

This revision now requires changes to proceed.Apr 11 2022, 4:13 PM