Page MenuHome
Differential D14653

Outliner: Add icon column to toggle if library overrides are editable
ClosedPublic
Actions

Authored by Julian Eisel (Severin) on Apr 14 2022, 6:17 PM.

Details

Reviewers
Bastien Montagne (mont29)
Commits
rB994da7077d4a: Outliner: Add icon column to toggle if library overrides are editable
Summary

Adds a column to the right in the Library Overrides Hierarchies view mode to toggle editability of library overrides.

Note that making a library override non-editable currently involves clearing all overridden properties. This is an arguable design choice, we should probably at least warn the user before doing this.

Part of T95802.

Diff Detail

Repository
rB Blender
Branch
temp-outliner-library-override-hierarchy
Build Status
Buildable 21644
Build 21644: arc lint + arc unit

Event Timeline

Julian Eisel (Severin) requested review of this revision.Apr 14 2022, 6:17 PM
Julian Eisel (Severin) created this revision.
Harbormaster completed remote builds in B21644: Diff 50456.Apr 14 2022, 6:17 PM
Julian Eisel (Severin) edited the summary of this revision. (Show Details)Apr 14 2022, 6:22 PM
Julian Eisel (Severin) added a project: Overrides.
Julian Eisel (Severin) mentioned this in T95802: Library Override - Outliner UI/UX.
Julian Eisel (Severin) mentioned this in D14654: Utils: Add macro for C++ default arguments in C headers.Apr 14 2022, 6:52 PM
Bastien Montagne (mont29) accepted this revision.Apr 20 2022, 4:00 PM

I think the CPP_ARG_DEFAULT macros have nothing to do in this patch?

Also, the whole set of changes to context and button comparison will be committed separately I assume?

Otherwise LGTM.

source/blender/editors/space_outliner/outliner_draw.cc
1851

Wonder though, are we sure this cannot lead to accessing freed memory?

source/blender/editors/space_outliner/outliner_utils.cc
327–332

could be a sub-switch?

source/blender/editors/util/ed_util_ops.cc
333

"Set if this library override data-block can be edited or not"

This revision is now accepted and ready to land.Apr 20 2022, 4:00 PM
Julian Eisel (Severin) added a comment.Apr 25 2022, 5:43 PM
In D14653#395171, @Bastien Montagne (mont29) wrote:

I think the CPP_ARG_DEFAULT macros have nothing to do in this patch?

It's used here, but I submitted it separately: D14654

Also, the whole set of changes to context and button comparison will be committed separately I assume?

Yeah makes sense.

Julian Eisel (Severin) mentioned this in rB5c5ec837b3a5: Utils: Add macro for C++ default arguments in C headers.Apr 26 2022, 3:47 PM
Closed by commit rB994da7077d4a: Outliner: Add icon column to toggle if library overrides are editable (authored by Julian Eisel (Severin)). · Explain WhyApr 26 2022, 10:31 PM
This revision was automatically updated to reflect the committed changes.
Julian Eisel (Severin) mentioned this in rB5fe1624b0eba: UI: Support setting context for buttons without layout.
Julian Eisel (Severin) mentioned this in rB83c8f996f161: UI: Add callback for comparing button identity.
Julian Eisel (Severin) marked 3 inline comments as done.
Julian Eisel (Severin) added a commit: rB994da7077d4a: Outliner: Add icon column to toggle if library overrides are editable.
Julian Eisel (Severin) added a comment.Apr 26 2022, 10:32 PM

Committed rB994da7077d4a, rB83c8f996f161 and rB5fe1624b0eba.

source/blender/editors/space_outliner/outliner_draw.cc
1851

Just tested again to confirm, I couldn't cause any issues with it over undo/redo. But should there be an issue, we're more likely to find it because of the dereferences, than if we'd just compare pointers.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
5 lines
intern/
23 lines
blenlib/
10 lines
editors/
include/
23 lines
interface/
24 lines
3 lines
5 lines
space_outliner/
92 lines
8 lines
util/
5 lines
48 lines

Diff 50456

View Options

source/blender/blenkernel/BKE_context.h

Loading...
View Options

source/blender/blenkernel/intern/context.c

Loading...
View Options

source/blender/blenlib/BLI_utildefines.h

Loading...
View Options

source/blender/editors/include/UI_interface.h

Loading...
View Options

source/blender/editors/interface/interface.cc

Loading...
View Options

source/blender/editors/interface/interface_intern.h

Loading...
View Options

source/blender/editors/interface/interface_utils.cc

Loading...
View Options

source/blender/editors/space_outliner/outliner_draw.cc

Loading...
View Options

source/blender/editors/space_outliner/outliner_utils.cc

Loading...
View Options

source/blender/editors/util/CMakeLists.txt

Loading...
View Options

source/blender/editors/util/ed_util_ops.cc

Loading...