Page MenuHome

Fix T97366: Misdetection of numbers as UDIMs in certain filepaths
ClosedPublic

Authored by Jesse Yurkovich (deadpin) on Apr 16 2022, 11:08 AM.

Details

Summary

In some circumstances singular files with numbers in their name (like
turntable-1080p.png) might be detected as a UDIM.

The root cause in this particular instance was because BKE_image_get_tile_info
believed this file to be a tiled texture and replaced the filename with
a tokenized version of it. However, later on, the code inside image_open_single
did not believe it was tiled because only 1 file was detected and our
tiled textures require at least 2. This discrepancy lead to the broken
filename situation.

This was a regression since rB180b66ae8a1f as that introduced the
tokenization changes.

Diff Detail

Repository
rB Blender

Event Timeline

Jesse Yurkovich (deadpin) requested review of this revision.Apr 16 2022, 11:08 AM
Jesse Yurkovich (deadpin) created this revision.
  • Lost change in the shuffle

LGTM.

I've left two cleanup suggestions, but they don't really need a second round of review.

source/blender/blenkernel/intern/image.cc
3109
3127
3141–3146
This revision is now accepted and ready to land.Apr 16 2022, 10:16 PM