Page MenuHome
Differential D14668

Change Vertex Colors panel to Attributes in Node Wrangler
ClosedPublic
Actions

Authored by Ramil Roosileht (Limarest) on Apr 16 2022, 7:21 PM.

Details

Reviewers
Julien Kaspar (JulienKaspar)
Joseph Eagar (joeedh)
Brecht Van Lommel (brecht)
Maniphest Tasks
T97105: Update "Vertex Color" options in add menu of shader editor
Commits
rBAdde5915336d5: Fix T97105: change Vertex Colors menu to Attributes in Node Wrangler
Summary

Fixes T97105

Supports any attribute:

Test file:

VcolsTest.blend4 MBDownload

Diff Detail

Event Timeline

Ramil Roosileht (Limarest) requested review of this revision.Apr 16 2022, 7:21 PM
Ramil Roosileht (Limarest) created this revision.
Brecht Van Lommel (brecht) requested changes to this revision.Apr 20 2022, 6:30 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).
Brecht Van Lommel (brecht) added inline comments.
node_wrangler.py
4558

Can you rename this class too? NWColorAttributeMenu

4560

Keep it plural: Color Attributes

This revision now requires changes to proceed.Apr 20 2022, 6:30 PM
Julien Kaspar (JulienKaspar) added a comment.Apr 20 2022, 7:03 PM

In the recent meeting we discussed that the addon should support any attribute, not just color attributes. The patch could be updated to reflect that. That would be more useful.

Ramil Roosileht (Limarest) updated this revision to Diff 50625.Apr 20 2022, 9:43 PM
Ramil Roosileht (Limarest) retitled this revision from Change Vertex Colors panel to Color Attributes in Node Wrangler to Change Vertex Colors panel to Attributes in Node Wrangler.
Ramil Roosileht (Limarest) edited the summary of this revision. (Show Details)
  • Updated diff to support any attribute, not just color attributes
  • Renamed a bunch of variables to reflect changes

Ramil Roosileht (Limarest) marked 2 inline comments as done.Apr 20 2022, 9:46 PM
serge (rpserge) awarded a token.Apr 20 2022, 10:17 PM
Julien Kaspar (JulienKaspar) accepted this revision.Apr 20 2022, 11:25 PM

From a user perspective this looks like the ideal way to go. If it's good on the code side to the others, then we should go ahead and commit this 👍

Joseph Eagar (joeedh) added a comment.Apr 21 2022, 7:29 AM

Should we move this into the main ui scripts and not have it inside an add-on?

Brecht Van Lommel (brecht) accepted this revision.Apr 21 2022, 3:37 PM
This revision is now accepted and ready to land.Apr 21 2022, 3:37 PM
Closed by commit rBAdde5915336d5: Fix T97105: change Vertex Colors menu to Attributes in Node Wrangler (authored by Ramil Roosileht (Limarest), committed by Brecht Van Lommel (brecht)). · Explain WhyApr 21 2022, 3:39 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rBAdde5915336d5: Fix T97105: change Vertex Colors menu to Attributes in Node Wrangler.
Brecht Van Lommel (brecht) added a comment.Apr 21 2022, 4:26 PM

It may be good to make this built-in, but I don't think this implementation is really polished enough for master.

I'll look at adding autocomplete to the Attribute name field though, which should help.

Revision Contents
Changeset List

PathSize
32 lines

Diff 50625

View Options

node_wrangler.py

Loading...