Fix T96414: Stencil mapping is incorrect for UDIMs
ClosedPublic
Actions

Authored by Jesse Yurkovich (deadpin) on Apr 17 2022, 11:44 AM.

Details

Reviewers

Brecht Van Lommel (brecht)
Jeroen Bakker (jbakker)

Maniphest Tasks

T96414: Painting on UDIMs with texture mapped as stencil

Commits

rB210d0f1b801f: Fix T96414: Stencil mapping is incorrect for UDIMs

Summary

When texture painting, brush textures and brush texture masks were not
transformed to account for UDIMs tiles.

This simply transforms the stencil mapping rect according to the tile
being painted/sampled.

This would be a candidate for 2.83 and 2.93 if accepted.

Diff Detail

Repository

rB Blender

Branch

udim-fixT96414-stencil (branched from master)

Build Status

Buildable 21660
Build 21660: arc lint + arc unit

Event Timeline

Jesse Yurkovich (deadpin) requested review of this revision.Apr 17 2022, 11:44 AM

Jesse Yurkovich (deadpin) created this revision.

Harbormaster completed remote builds in B21660: Diff 50514.Apr 17 2022, 11:44 AM

Jesse Yurkovich (deadpin) added a task: T96414: Painting on UDIMs with texture mapped as stencil .Apr 17 2022, 11:46 AM

Jesse Yurkovich (deadpin) added a reviewer: Philipp Oeser (lichtwerk).

Is it just me, or are we running into artifacts now?

Think it would be good if @Brecht Van Lommel (brecht) and @Jeroen Bakker (jbakker) could check on this

Yes, in particular, smaller brush sizes are affected a lot more than larger and it seems very "view / zoom" dependent. Zooming in and making each tile larger will sample much better from the brush. I can reproduce similar artifacts on master even with non-tiled images:

Top image: Zoomed out, small brush size
Middle image: Zoomed in a bit, large brush size
Bottom image: Zoomed in a bit, small brush size

In D14671#394867, @Jesse Yurkovich (deadpin) wrote:

Yes, in particular, smaller brush sizes are affected a lot more than larger and it seems very "view / zoom" dependent. Zooming in and making each tile larger will sample much better from the brush. I can reproduce similar artifacts on master even with non-tiled images:

Top image: Zoomed out, small brush size
Middle image: Zoomed in a bit, large brush size
Bottom image: Zoomed in a bit, small brush size

Will have to check on master still (had the impression this was a lot more noticeable on "higher" UDIMs...)
Maybe @Lukas Stockner (lukasstockner97) wants to check this one here, too?

Maybe the rounding to integers in brush_painter_2d_tex_mapping causes problem, it's not immediately obvious to me why that's done.

Use floats instead or rounding to ints

Harbormaster completed remote builds in B22012: Diff 51262.May 7 2022, 7:44 AM

Oh, good idea. That does help greatly for me at least. The distortion was minimal on my 4k display before using floats and slightly improved after. For 1080p though I'm seeing much better results after using them.

@Philipp Oeser (lichtwerk) mind giving this a try again and see if it helps your case?

Brecht Van Lommel (brecht) accepted this revision.May 10 2022, 7:45 PM

This revision is now accepted and ready to land.May 10 2022, 7:45 PM

In D14671#400300, @Jesse Yurkovich (deadpin) wrote:

Oh, good idea. That does help greatly for me at least. The distortion was minimal on my 4k display before using floats and slightly improved after. For 1080p though I'm seeing much better results after using them.

@Philipp Oeser (lichtwerk) mind giving this a try again and see if it helps your case?

Sorry this slipped through.
Yep, can confirm the artifacts are also gone for me now, thx!

Closed by commit rB210d0f1b801f: Fix T96414: Stencil mapping is incorrect for UDIMs (authored by Jesse Yurkovich (deadpin)). · Explain WhyMay 17 2022, 9:29 AM

This revision was automatically updated to reflect the committed changes.

Jesse Yurkovich (deadpin) added a commit: rB210d0f1b801f: Fix T96414: Stencil mapping is incorrect for UDIMs.