Page MenuHome
Differential D14704

Fix T97465: Moving compositor BG image cannot be cancelled
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Apr 20 2022, 3:42 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Maniphest Tasks
T97465: Cannot stop moving background image with escape in Compositor
Commits
rB298e9c7ebd3b: Fix T97465: Moving compositor BG image cannot be cancelled
Summary

This was possible with the gizmo, but no using the operator (e.g. from
the sidebar).

Now store original offsets and reset to these on calcel (ESC or RMB).

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Apr 20 2022, 3:42 PM
Philipp Oeser (lichtwerk) created this revision.
Philipp Oeser (lichtwerk) added a task: T97465: Cannot stop moving background image with escape in Compositor.
Campbell Barton (campbellbarton) accepted this revision.Apr 21 2022, 10:01 AM
Campbell Barton (campbellbarton) added inline comments.
source/blender/editors/space_node/node_view.cc
183

Best use x/yofs_orig otherwise it's not clear when reading the code elsewhere these are stored values (and not some other kind of offset).

This revision is now accepted and ready to land.Apr 21 2022, 10:01 AM
Closed by commit rB298e9c7ebd3b: Fix T97465: Moving compositor BG image cannot be cancelled (authored by Philipp Oeser (lichtwerk)). · Explain WhyApr 21 2022, 10:34 AM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB298e9c7ebd3b: Fix T97465: Moving compositor BG image cannot be cancelled.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_node/
19 lines

Diff 50619

View Options

source/blender/editors/space_node/node_view.cc

Loading...